You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2015/02/05 17:49:44 UTC
Review Request 30670: Call to save configs of different services
together should 400 return code not 500
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30670/
-----------------------------------------------------------
Review request for Ambari and John Speidel.
Bugs: AMBARI-9495
https://issues.apache.org/jira/browse/AMBARI-9495
Repository: ambari
Description
-------
This AmbariException will need to be caught upstream and translated to an
IllegalArgumentException (or thrown from here) which will result in the
expected 400 Bad Request response back to the user. If the AmbariException is
not caught, it will result in a 500 Server Error to the user which is not
appropriate.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 514c8e0
ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 4a8c020
ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java bb6a713
ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java f65bbd9
Diff: https://reviews.apache.org/r/30670/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 30670: Call to save configs of different services
together should 400 return code not 500
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30670/#review71232
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Onischuk
On Feb. 5, 2015, 4:49 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30670/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2015, 4:49 p.m.)
>
>
> Review request for Ambari and John Speidel.
>
>
> Bugs: AMBARI-9495
> https://issues.apache.org/jira/browse/AMBARI-9495
>
>
> Repository: ambari
>
>
> Description
> -------
>
> This AmbariException will need to be caught upstream and translated to an
> IllegalArgumentException (or thrown from here) which will result in the
> expected 400 Bad Request response back to the user. If the AmbariException is
> not caught, it will result in a 500 Server Error to the user which is not
> appropriate.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 514c8e0
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 4a8c020
> ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java bb6a713
> ambari-server/src/test/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostTest.java f65bbd9
>
> Diff: https://reviews.apache.org/r/30670/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>