You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "veghlaci05 (via GitHub)" <gi...@apache.org> on 2023/05/16 08:00:01 UTC
[GitHub] [hive] veghlaci05 opened a new pull request, #4328: HIVE-27343: Fix flaky tests: TestHiveMetaStoreTimeout#testResetTimeout
veghlaci05 opened a new pull request, #4328:
URL: https://github.com/apache/hive/pull/4328
### What changes were proposed in this pull request?
Fix the flaky test:
TestHiveMetaStoreTimeout#testResetTimeout
### Why are the changes needed?
This test was sensitive to network/DB speed, and slow CI builds were resulted in unexpected timeouts.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
By running TestHiveMetaStoreTimeout#testResetTimeout manually
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] veghlaci05 commented on a diff in pull request #4328: HIVE-27343: Fix flaky tests: TestHiveMetaStoreTimeout#testResetTimeout
Posted by "veghlaci05 (via GitHub)" <gi...@apache.org>.
veghlaci05 commented on code in PR #4328:
URL: https://github.com/apache/hive/pull/4328#discussion_r1196504217
##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreTimeout.java:
##########
@@ -117,11 +117,11 @@ public void testTimeout() throws Exception {
@Test
public void testResetTimeout() throws Exception {
- HMSHandler.testTimeoutValue = 250;
String dbName = "db";
// no timeout before reset
client.dropDatabase(dbName, true, true);
+ HMSHandler.testTimeoutValue = 250;
Review Comment:
Good idea, I'll rewrite the test methods that way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] veghlaci05 commented on a diff in pull request #4328: HIVE-27343: Fix flaky tests: TestHiveMetaStoreTimeout#testResetTimeout
Posted by "veghlaci05 (via GitHub)" <gi...@apache.org>.
veghlaci05 commented on code in PR #4328:
URL: https://github.com/apache/hive/pull/4328#discussion_r1196136476
##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreTimeout.java:
##########
@@ -117,11 +117,11 @@ public void testTimeout() throws Exception {
@Test
public void testResetTimeout() throws Exception {
- HMSHandler.testTimeoutValue = 250;
String dbName = "db";
// no timeout before reset
client.dropDatabase(dbName, true, true);
+ HMSHandler.testTimeoutValue = 250;
Review Comment:
Originally the low timeout value was set at the beginning of the test. Normally it is high enough that `client.dropDatabase(dbName, true, true);` won't timeout, but `client.createDatabase(db);` will do. However, if the network/DB is very slow, even `client.dropDatabase(dbName, true, true);` can timeout causing the whole test to fail. Since the default value of the timeout is -1 (no timout) I moved the lowering the value after the dropdatabase call, so now it is no longer sensitive to the environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] veghlaci05 merged pull request #4328: HIVE-27343: Fix flaky tests: TestHiveMetaStoreTimeout#testResetTimeout
Posted by "veghlaci05 (via GitHub)" <gi...@apache.org>.
veghlaci05 merged PR #4328:
URL: https://github.com/apache/hive/pull/4328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] veghlaci05 commented on a diff in pull request #4328: HIVE-27343: Fix flaky tests: TestHiveMetaStoreTimeout#testResetTimeout
Posted by "veghlaci05 (via GitHub)" <gi...@apache.org>.
veghlaci05 commented on code in PR #4328:
URL: https://github.com/apache/hive/pull/4328#discussion_r1196136476
##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreTimeout.java:
##########
@@ -117,11 +117,11 @@ public void testTimeout() throws Exception {
@Test
public void testResetTimeout() throws Exception {
- HMSHandler.testTimeoutValue = 250;
String dbName = "db";
// no timeout before reset
client.dropDatabase(dbName, true, true);
+ HMSHandler.testTimeoutValue = 250;
Review Comment:
Originally the low timeout value was set at the beginning of the test. Normally it is high enough that `client.dropDatabase(dbName, true, true);` won't timeout, but `client.createDatabase(db);` will do. However, if the network/DB is very slow, even `client.dropDatabase(dbName, true, true);` can timeout causing the whole test to fail. Since the default value of the timeout is -1 (no timout) I moved the lowering the value after the dropdatabase call, and restored -1 after createDatabase fail, so now the test is no longer sensitive to the environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #4328: HIVE-27343: Fix flaky tests: TestHiveMetaStoreTimeout#testResetTimeout
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4328:
URL: https://github.com/apache/hive/pull/4328#issuecomment-1550010511
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4328)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4328&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4328&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4328&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4328&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4328&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4328&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4328&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4328&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4328&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4328&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4328&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4328&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4328&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4328&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] InvisibleProgrammer commented on a diff in pull request #4328: HIVE-27343: Fix flaky tests: TestHiveMetaStoreTimeout#testResetTimeout
Posted by "InvisibleProgrammer (via GitHub)" <gi...@apache.org>.
InvisibleProgrammer commented on code in PR #4328:
URL: https://github.com/apache/hive/pull/4328#discussion_r1196289477
##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreTimeout.java:
##########
@@ -117,11 +117,11 @@ public void testTimeout() throws Exception {
@Test
public void testResetTimeout() throws Exception {
- HMSHandler.testTimeoutValue = 250;
String dbName = "db";
// no timeout before reset
client.dropDatabase(dbName, true, true);
+ HMSHandler.testTimeoutValue = 250;
Review Comment:
The setup method of the test enables timeout. What about playing with the timeout values, just disabling timeout at the beginning of the test case and re-enable it after the drop database command?
And also, I wonder why the test `testNoTimeout` is not flaky. It works with the same timeout value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] veghlaci05 commented on a diff in pull request #4328: HIVE-27343: Fix flaky tests: TestHiveMetaStoreTimeout#testResetTimeout
Posted by "veghlaci05 (via GitHub)" <gi...@apache.org>.
veghlaci05 commented on code in PR #4328:
URL: https://github.com/apache/hive/pull/4328#discussion_r1196136476
##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreTimeout.java:
##########
@@ -117,11 +117,11 @@ public void testTimeout() throws Exception {
@Test
public void testResetTimeout() throws Exception {
- HMSHandler.testTimeoutValue = 250;
String dbName = "db";
// no timeout before reset
client.dropDatabase(dbName, true, true);
+ HMSHandler.testTimeoutValue = 250;
Review Comment:
Originally the low timeout value was set at the beginning of the test. Normally it is high enough that `client.dropDatabase(dbName, true, true);` won't fail, but `client.createDatabase(db);` will do. However, if the network/DB is very slow, even `client.dropDatabase(dbName, true, true);` can fail causing the whole test to fail. Since the default value of the timeout is -1 (no timout) I moved the lowering the value after the dropdatabase call, so now it is no longer sensitive to the environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] InvisibleProgrammer commented on pull request #4328: HIVE-27343: Fix flaky tests: TestHiveMetaStoreTimeout#testResetTimeout
Posted by "InvisibleProgrammer (via GitHub)" <gi...@apache.org>.
InvisibleProgrammer commented on PR #4328:
URL: https://github.com/apache/hive/pull/4328#issuecomment-1552602042
LGTM. Init timeout failed at precommits so please restart the tests. Anyway, the test cases were all green so it seem we are good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #4328: HIVE-27343: Fix flaky tests: TestHiveMetaStoreTimeout#testResetTimeout
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4328:
URL: https://github.com/apache/hive/pull/4328#issuecomment-1553006063
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4328)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4328&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4328&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4328&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4328&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4328&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4328&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4328&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4328&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4328&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4328&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4328&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4328&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4328&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4328&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] aturoczy commented on a diff in pull request #4328: HIVE-27343: Fix flaky tests: TestHiveMetaStoreTimeout#testResetTimeout
Posted by "aturoczy (via GitHub)" <gi...@apache.org>.
aturoczy commented on code in PR #4328:
URL: https://github.com/apache/hive/pull/4328#discussion_r1195710817
##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreTimeout.java:
##########
@@ -117,11 +117,11 @@ public void testTimeout() throws Exception {
@Test
public void testResetTimeout() throws Exception {
- HMSHandler.testTimeoutValue = 250;
String dbName = "db";
// no timeout before reset
client.dropDatabase(dbName, true, true);
+ HMSHandler.testTimeoutValue = 250;
Review Comment:
I don't get it how this config will resolve the issue. Could you please elaborate it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #4328: HIVE-27343: Fix flaky tests: TestHiveMetaStoreTimeout#testResetTimeout
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4328:
URL: https://github.com/apache/hive/pull/4328#issuecomment-1551906889
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4328)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4328&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4328&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4328&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4328&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4328&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4328&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4328&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4328&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4328&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4328&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4328&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4328&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4328&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4328&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org