You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by mwkang <gi...@git.apache.org> on 2016/08/20 08:43:10 UTC
[GitHub] zeppelin pull request #1350: [ZEPPELIN-1351]Paragraph status should be ERROR...
GitHub user mwkang opened a pull request:
https://github.com/apache/zeppelin/pull/1350
[ZEPPELIN-1351]Paragraph status should be ERROR if Paragraph is terminated with SIGTERM
### What is this PR for?
When Paragraph received a SIGTERM. ExitValue: 143, Status of the paragraph should be marked as "ERROR" instead of "FINISHED".
### What type of PR is it?
Bug Fix
### Todos
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1351
### How should this be tested?
I have online test.
But hope to get some advice or guides from reviewers or committer.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mwkang/zeppelin ZEPPELIN-1351
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1350.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1350
----
commit 300db3f2dca5f7171de7fddc3c59e75bc022ca6f
Author: Minwoo Kang <mi...@outlook.com>
Date: 2016-08-20T08:34:44Z
While Code.INCOMPLETE, Set Status.ERROR
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1350: [ZEPPELIN-1351]Paragraph status should be ERROR if Par...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1350
@Leemoonsoo When paragraph received a SIGTERM, Job result code is INCOMPLETE.
Before When Job result code is INCOMPLETE, Status is FINISHED.
I think in this situation user can not realize paragraph received a SIGTERM. Because Status is FINISHED.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1350: [ZEPPELIN-1351]Paragraph status should be ERROR if Par...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1350
I added test. Please review PR, thanks for your consideration.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1350: [ZEPPELIN-1351]Paragraph status should be ERROR if Par...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1350
is it possible to add some unit test for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1350: [ZEPPELIN-1351]Paragraph status should be ERROR if Par...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1350
Thanks for the contribution.
@mwkang Could you elaborate little bit more how this code change is related to ZEPPELIN-1351?
ZEPPELIN-1351 is about displaying paragraph status when it fails with "Paragraph received a SIGTERM. ExitValue: 143". But code change here is displaying paragraph status 'ERROR' when interpreter result is incomplete. So i'm bit confusion how they're related. Could you help me to understand?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1350: [ZEPPELIN-1351]Paragraph status should be ERROR if Par...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1350
I am not sure what is my next step. And this PR was created very long time ago. So enviroment changed before. I think other contributor can resolve better than me. So I closed this PR.
Thanks for your patient.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1350: [ZEPPELIN-1351]Paragraph status should be ERROR...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang closed the pull request at:
https://github.com/apache/zeppelin/pull/1350
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1350: [ZEPPELIN-1351]Paragraph status should be ERROR if Par...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1350
Can anyone help this PR?
I don't know the next step.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1350: [ZEPPELIN-1351]Paragraph status should be ERROR if Par...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1350
@felixcheung Okay! I will add unit test. Thanks for your comment!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---