You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/04/27 22:36:18 UTC

[GitHub] [hudi] alexeykudinkin opened a new pull request, #5453: [WIP] Fixing unnecessary deserialization loop for DataSource V2 batch-writing API

alexeykudinkin opened a new pull request, #5453:
URL: https://github.com/apache/hudi/pull/5453

   ## *Tips*
   - *Thank you very much for contributing to Apache Hudi.*
   - *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
   
   ## What is the purpose of the pull request
   
   Fixing unnecessary deserialization loop for DataSource V2 batch-writing API: it previously was relying on the API that was triggering the de-/serialization loop (from `InternalRow` to `Row` and back). 
   
   ## Brief change log
   
    - Adding `mapInternal` util to `HoodieUnsafeCatalystUtil`
    - Fixed perf hit in Spark DataSource V2 w/ avoidable de/-serialization loop
    - Tidying up
   
   ## Verify this pull request
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #5453: [WIP] Fixing unnecessary deserialization loop for DataSource V2 batch-writing API

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5453:
URL: https://github.com/apache/hudi/pull/5453#issuecomment-1111559411

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "74f6177886e338df24c4bfcfaab53e3eab7f00f4",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "74f6177886e338df24c4bfcfaab53e3eab7f00f4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 74f6177886e338df24c4bfcfaab53e3eab7f00f4 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] alexeykudinkin closed pull request #5453: [WIP] Fixing unnecessary deserialization loop for DataSource V2 batch-writing API

Posted by GitBox <gi...@apache.org>.
alexeykudinkin closed pull request #5453: [WIP] Fixing unnecessary deserialization loop for DataSource V2 batch-writing API
URL: https://github.com/apache/hudi/pull/5453


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #5453: [WIP] Fixing unnecessary deserialization loop for DataSource V2 batch-writing API

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5453:
URL: https://github.com/apache/hudi/pull/5453#issuecomment-1111623168

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "74f6177886e338df24c4bfcfaab53e3eab7f00f4",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8350",
       "triggerID" : "74f6177886e338df24c4bfcfaab53e3eab7f00f4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 74f6177886e338df24c4bfcfaab53e3eab7f00f4 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8350) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #5453: [WIP] Fixing unnecessary deserialization loop for DataSource V2 batch-writing API

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5453:
URL: https://github.com/apache/hudi/pull/5453#issuecomment-1111561178

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "74f6177886e338df24c4bfcfaab53e3eab7f00f4",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8350",
       "triggerID" : "74f6177886e338df24c4bfcfaab53e3eab7f00f4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 74f6177886e338df24c4bfcfaab53e3eab7f00f4 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8350) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] alexeykudinkin commented on pull request #5453: [WIP] Fixing unnecessary deserialization loop for DataSource V2 batch-writing API

Posted by GitBox <gi...@apache.org>.
alexeykudinkin commented on PR #5453:
URL: https://github.com/apache/hudi/pull/5453#issuecomment-1221175389

   Closing in favor of https://github.com/apache/hudi/pull/6361


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org