You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/14 17:22:22 UTC

[GitHub] [pulsar] merlimat commented on a change in pull request #7528: Fix: function BC issue introduced in 2.6

merlimat commented on a change in pull request #7528:
URL: https://github.com/apache/pulsar/pull/7528#discussion_r454518289



##########
File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/FunctionWorkerStarter.java
##########
@@ -66,11 +66,12 @@ public static void main(String[] args) throws Exception {
         try {
             worker.start();
         } catch (Throwable th) {
+            log.error("Encountered error in function worker.", th);
             worker.stop();
             System.exit(-1);

Review comment:
       System.exit() is not always guaranteed to take the process down (eg: hanging threads). Use `Runtime.halt()` instead




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org