You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2023/12/06 19:51:44 UTC
[Impala-ASF-CR] IMPALA-10949: Improve batching logic of partition events
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/20485 )
Change subject: IMPALA-10949: Improve batching logic of partition events
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/20485/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java
File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java:
http://gerrit.cloudera.org:8080/#/c/20485/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1282
PS1, Line 1282: n
If we already check getLastSyncedEventId(), wouldn't it be simpler to drop the event before creating batches?
http://gerrit.cloudera.org:8080/#/c/20485/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@1284
PS1, Line 1284: try {
: org.apache.impala.catalog.Table tbl = catalog_.getTable(dbName_, tblName_);
: if (tbl != null && tbl.getLastSyncedEventId() >= event.getEventId()) {
: return false;
: }
: } catch (CatalogException e) {
: debugLog("ignoring exception while fetching from cache on table {}.{}",
: dbName_, tblName_, e);
: }
This seems to be the same as for alter table events - a function like bool MetastoreEvent.newerThanLastSyncedEventId() could be created to reduce duplication.
--
To view, visit http://gerrit.cloudera.org:8080/20485
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e79510739347cbe669719a9e4cb9cabd5daa7d3
Gerrit-Change-Number: 20485
Gerrit-PatchSet: 1
Gerrit-Owner: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <k....@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <sa...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Dec 2023 19:51:44 +0000
Gerrit-HasComments: Yes