[GitHub] kpm1985 commented on issue #1039: FLUO-1038 Use try with resources for streams in FluoAdminImpl

[GitBox <gi...@apache.org>]

kpm1985 commented on issue #1039: FLUO-1038 Use try with resources for streams in FluoAdminImpl
URL: https://github.com/apache/fluo/pull/1039#issuecomment-396398261
 
 
   Thank you, I will avoid duplication.
   
   As you noted behavior is a rollover from jira based projects (Nutch/Log4J2)
   and I apologise and thank you.
   
    In Jira you get complained for NOT filing an issue first, I will adapt for
   our awesome project.
   
   
   
   On Mon, Jun 11, 2018, 2:34 PM Christopher Tubbs <no...@github.com>
   wrote:
   
   > @kpm1985 <https://github.com/kpm1985> If you reference GitHub issues as
   > "Fix #1038 <https://github.com/apache/fluo/issues/1038>" instead of
   > "FLUO-1038" in your commit message, it will auto-close the referenced issue
   > once the PR is merged. The PROJECT-#### format isn't *wrong*, but it is
   > more typical for projects using JIRA, which this project does not.
   >
   > Also, there is no need to create an issue *and* a PR if you are
   > submitting them at (or near) the same time. Since PRs *are* issues, the
   > PR will suffice. Typically, an issue is created first, only if the work is
   > not submitted immediately and a placeholder is needed, or if it warrants
   > discussion prior to starting the work, or if it's an umbrella issue
   > covering several subsequent smaller issues/PRs.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/fluo/pull/1039#issuecomment-396394775>, or mute
   > the thread
   > <https://github.com/notifications/unsubscribe-auth/Acg-LMmrfV2JI4RoAhEkeYtXRd-JiJLxks5t7uJ4gaJpZM4UiFak>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services