You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ms...@apache.org on 2020/10/17 18:16:27 UTC

svn commit: r1882603 - /pdfbox/trunk/preflight/src/main/java/org/apache/pdfbox/preflight/process/AcroFormValidationProcess.java

Author: msahyoun
Date: Sat Oct 17 18:16:27 2020
New Revision: 1882603

URL: http://svn.apache.org/viewvc?rev=1882603&view=rev
Log:
PDFBOX-4985 do a low level check for NeedAppearances as PD access model will fix the error

Modified:
    pdfbox/trunk/preflight/src/main/java/org/apache/pdfbox/preflight/process/AcroFormValidationProcess.java

Modified: pdfbox/trunk/preflight/src/main/java/org/apache/pdfbox/preflight/process/AcroFormValidationProcess.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/preflight/src/main/java/org/apache/pdfbox/preflight/process/AcroFormValidationProcess.java?rev=1882603&r1=1882602&r2=1882603&view=diff
==============================================================================
--- pdfbox/trunk/preflight/src/main/java/org/apache/pdfbox/preflight/process/AcroFormValidationProcess.java (original)
+++ pdfbox/trunk/preflight/src/main/java/org/apache/pdfbox/preflight/process/AcroFormValidationProcess.java Sat Oct 17 18:16:27 2020
@@ -24,6 +24,7 @@ package org.apache.pdfbox.preflight.proc
 import java.io.IOException;
 import java.util.List;
 import org.apache.pdfbox.cos.COSBase;
+import org.apache.pdfbox.cos.COSDictionary;
 import org.apache.pdfbox.cos.COSName;
 import org.apache.pdfbox.pdmodel.PDDocumentCatalog;
 import org.apache.pdfbox.pdmodel.interactive.action.PDFormFieldAdditionalActions;
@@ -54,10 +55,17 @@ public class AcroFormValidationProcess e
         PDDocumentCatalog catalog = ctx.getDocument().getDocumentCatalog();
         if (catalog != null)
         {
+            // PDFBOX-4985 regenerates appearnce streams for fields when doing a PD model
+            // access to the AcroForm and in turn sets a NeedAppearances flag to false
+            // do a low level check for the NeedAppearances flag
+            COSDictionary cosAcroForm = catalog.getCOSObject().getCOSDictionary(COSName.ACRO_FORM);
+            if (cosAcroForm != null) {
+                checkNeedAppearences(ctx, cosAcroForm);
+            } 
+
             PDAcroForm acroForm = catalog.getAcroForm();
             if (acroForm != null)
             {
-                checkNeedAppearences(ctx, acroForm);
                 try
                 {
                     exploreFields(ctx, acroForm.getFields());
@@ -82,9 +90,9 @@ public class AcroFormValidationProcess e
      * @param ctx the preflight context.
      * @param acroForm the AcroForm.
      */
-    protected void checkNeedAppearences(PreflightContext ctx, PDAcroForm acroForm)
+    protected void checkNeedAppearences(PreflightContext ctx, COSDictionary cosAcroForm)
     {
-        if (acroForm.getCOSObject().getBoolean(COSName.NEED_APPEARANCES, false))
+        if (cosAcroForm.getBoolean(COSName.NEED_APPEARANCES, false))
         {
             addValidationError(ctx, new ValidationError(ERROR_SYNTAX_DICT_INVALID,
                     "NeedAppearance is present with the value \"true\""));