[jira] [Commented] (COUCHDB-954) typo in key tree logic when latest=true

["Adam Kocoloski (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/COUCHDB-954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13091255#comment-13091255 ] 

Adam Kocoloski commented on COUCHDB-954:
----------------------------------------

Now that latest=true works I really probably should fix this one.  Confirmed that Jan's test exercises the code path, will try to write one with real client operations too.

> typo in key tree logic when latest=true
> ---------------------------------------
>
>                 Key: COUCHDB-954
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-954
>             Project: CouchDB
>          Issue Type: Bug
>          Components: Database Core
>            Reporter: Adam Kocoloski
>            Assignee: Adam Kocoloski
>
> This line
> https://github.com/apache/couchdb/blob/7fe84eba9982ebb3bcaa48b7aa28fdd2e130422d/src/couchdb/couch_key_tree.erl#L195
> seems like it should read KeysToGet3 = KeysToGet2 -- LeafKeysFound, and then KeysToGet3 should be supplied to the following invocation of get_key_leafs_simple.  I think the current code would crash if a user made an open_revs call with latest=true and a pair of revisions that have a parent/child relationship, or at least it would crash if latest=true was implemented (COUCHDB-953).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira