You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hugegraph.apache.org by GitBox <gi...@apache.org> on 2022/05/31 15:19:16 UTC

[GitHub] [incubator-hugegraph] Linary commented on a diff in pull request #1891: Add system schema store

Linary commented on code in PR #1891:
URL: https://github.com/apache/incubator-hugegraph/pull/1891#discussion_r885775358


##########
hugegraph-test/src/main/java/com/baidu/hugegraph/unit/UnitTestSuite.java:
##########
@@ -108,11 +110,12 @@
     SecurityManagerTest.class,
     RolePermissionTest.class,
     ExceptionTest.class,
-    BackendStoreSystemInfoTest.class,
+    BackendStoreInfoTest.class,
     TraversalUtilTest.class,
     PageStateTest.class,
+    SystemSchemaStoreTest.class,
 
-    /* serializer */
+        /* serializer */

Review Comment:
   align



##########
hugegraph-test/src/main/java/com/baidu/hugegraph/api/EdgeApiTest.java:
##########
@@ -21,13 +21,14 @@
 
 import java.io.IOException;
 
-import jakarta.ws.rs.core.Response;
 import org.junit.Before;
 import org.junit.Test;
 
 import com.baidu.hugegraph.testutil.Assert;
 import com.google.common.collect.ImmutableMap;
 
+import jakarta.ws.rs.core.Response;

Review Comment:
   seems can remove



##########
hugegraph-core/src/main/java/com/baidu/hugegraph/auth/AuthManager.java:
##########
@@ -29,6 +29,7 @@
 
 public interface AuthManager {
 
+    void init();

Review Comment:
   add an empty line



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hugegraph.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org