You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2023/05/29 11:58:57 UTC
[GitHub] [pulsar] codecov-commenter commented on pull request #20416: [improve] [broker] Avoid `PersistentSubscription.expireMessages` logic check backlog twice.
codecov-commenter commented on PR #20416:
URL: https://github.com/apache/pulsar/pull/20416#issuecomment-1567043628
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/20416?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#20416](https://app.codecov.io/gh/apache/pulsar/pull/20416?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (5e1d23f) into [master](https://app.codecov.io/gh/apache/pulsar/commit/aa3bfcda6935dc2d9c69dce51f96ba80baeae0b7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (aa3bfcd) will **increase** coverage by `0.02%`.
> The diff coverage is `50.00%`.
[](https://app.codecov.io/gh/apache/pulsar/pull/20416?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #20416 +/- ##
============================================
+ Coverage 72.90% 72.93% +0.02%
- Complexity 31864 31897 +33
============================================
Files 1864 1864
Lines 138416 138416
Branches 15188 15188
============================================
+ Hits 100919 100954 +35
+ Misses 29477 29458 -19
+ Partials 8020 8004 -16
```
| Flag | Coverage Δ | |
|---|---|---|
| inttests | `24.26% <0.00%> (+0.09%)` | :arrow_up: |
| systests | `24.92% <0.00%> (-0.14%)` | :arrow_down: |
| unittests | `72.23% <50.00%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/pulsar/pull/20416?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ker/service/persistent/PersistentSubscription.java](https://app.codecov.io/gh/apache/pulsar/pull/20416?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL3BlcnNpc3RlbnQvUGVyc2lzdGVudFN1YnNjcmlwdGlvbi5qYXZh) | `75.43% <50.00%> (ø)` | |
... and [75 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/20416/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org