You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Greg Stein <gs...@lyra.org> on 1999/10/21 01:22:30 UTC

Re: cvs commit: apache-2.0/src/lib/apr/include apr_errno.h

While making this change, I also noticed the #ifdef sequences to define
things like APR_EINVAL based on EINVAL or a specific number. Those numbers
come from the 3000 range, but it seems they should also be based on
OS_START_ERROR. Thoughts?

Also, should it be APR_OS_START_ERROR to avoid namespace conflicts?

Cheers,
-g

On 20 Oct 1999 gstein@hyperreal.org wrote:
> gstein      99/10/20 16:14:14
> 
>   Modified:    src/lib/apr/include apr_errno.h
>   Log:
>   add parens so the macros bind properly in whatever context they're used.
>   
>   Revision  Changes    Path
>   1.5       +31 -31    apache-2.0/src/lib/apr/include/apr_errno.h

--
Greg Stein, http://www.lyra.org/


Re: cvs commit: apache-2.0/src/lib/apr/include apr_errno.h

Posted by Ryan Bloom <rb...@raleigh.ibm.com>.
On Wed, 20 Oct 1999, Greg Stein wrote:

> While making this change, I also noticed the #ifdef sequences to define
> things like APR_EINVAL based on EINVAL or a specific number. Those numbers
> come from the 3000 range, but it seems they should also be based on
> OS_START_ERROR. Thoughts
> 
> Also, should it be APR_OS_START_ERROR to avoid namespace conflicts?

Yep.  I'll do both of these things today.

Ryan

_______________________________________________________________________
Ryan Bloom		rbb@raleigh.ibm.com
4205 S Miami Blvd	
RTP, NC 27709		It's a beautiful sight to see good dancers 
			doing simple steps.  It's a painful sight to
			see beginners doing complicated patterns.