You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by br...@apache.org on 2015/01/02 23:12:13 UTC
svn commit: r1649136 - in
/commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats:
gif/GifReadTest.java icns/IcnsReadTest.java
Author: britter
Date: Fri Jan 2 22:12:12 2015
New Revision: 1649136
URL: http://svn.apache.org/r1649136
Log:
Remove unused variable and assertion that would never be executed
Modified:
commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/gif/GifReadTest.java
commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/icns/IcnsReadTest.java
Modified: commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/gif/GifReadTest.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/gif/GifReadTest.java?rev=1649136&r1=1649135&r2=1649136&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/gif/GifReadTest.java (original)
+++ commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/gif/GifReadTest.java Fri Jan 2 22:12:12 2015
@@ -51,8 +51,7 @@ public class GifReadTest extends GifBase
@Ignore(value = "RoundtripTest has to be fixed befor implementation can throw UnsupportedOperationException")
@Test(expected = UnsupportedOperationException.class)
public void testMetadata() throws Exception {
- final ImageMetadata metadata = Imaging.getMetadata(imageFile);
- assertNotNull(metadata);
+ Imaging.getMetadata(imageFile);
}
@Test
Modified: commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/icns/IcnsReadTest.java
URL: http://svn.apache.org/viewvc/commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/icns/IcnsReadTest.java?rev=1649136&r1=1649135&r2=1649136&view=diff
==============================================================================
--- commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/icns/IcnsReadTest.java (original)
+++ commons/proper/imaging/trunk/src/test/java/org/apache/commons/imaging/formats/icns/IcnsReadTest.java Fri Jan 2 22:12:12 2015
@@ -54,7 +54,7 @@ public class IcnsReadTest extends IcnsBa
@Ignore(value = "RoundtripTest has to be fixed befor implementation can throw UnsupportedOperationException")
@Test(expected = UnsupportedOperationException.class)
public void testImageMetadata() throws Exception {
- final ImageMetadata metadata = Imaging.getMetadata(imageFile);
+ Imaging.getMetadata(imageFile);
}
@Test