You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "hailin0 (via GitHub)" <gi...@apache.org> on 2023/05/07 16:06:06 UTC
[GitHub] [skywalking-banyandb] hailin0 opened a new pull request, #272: Fix resource corrupts caused by update indexRule operation
hailin0 opened a new pull request, #272:
URL: https://github.com/apache/skywalking-banyandb/pull/272
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes https://github.com/apache/skywalking/issues/<issue number>.
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking-banyandb/blob/main/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hanahmily merged pull request #272: Fix resource corrupts caused by update indexRule operation
Posted by "hanahmily (via GitHub)" <gi...@apache.org>.
hanahmily merged PR #272:
URL: https://github.com/apache/skywalking-banyandb/pull/272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hailin0 commented on pull request #272: Fix resource corrupts caused by update indexRule operation
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on PR #272:
URL: https://github.com/apache/skywalking-banyandb/pull/272#issuecomment-1537481362
operation steps：
1. create indexRule
2. update indexRule
3. query indexRule
reference
https://github.com/apache/skywalking-banyandb/blob/main/docs/crud/index_rule.md
throw error：
```shell
banyandb: resource corrupts.
```
exception code location：
https://github.com/apache/skywalking-banyandb/blob/main/banyand/metadata/schema/index.go#L102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] codecov-commenter commented on pull request #272: Fix resource corrupts caused by update indexRule operation
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #272:
URL: https://github.com/apache/skywalking-banyandb/pull/272#issuecomment-1537480965
## [Codecov](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/272?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#272](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/272?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c6f12c1) into [main](https://app.codecov.io/gh/apache/skywalking-banyandb/commit/e6d8953afc90e5ad2c9472e2a1e4aee25e50bcf9?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e6d8953) will **decrease** coverage by `0.03%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## main #272 +/- ##
==========================================
- Coverage 46.51% 46.48% -0.03%
==========================================
Files 89 89
Lines 9315 9321 +6
==========================================
Hits 4333 4333
- Misses 4577 4582 +5
- Partials 405 406 +1
```
| [Impacted Files](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/272?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [banyand/metadata/schema/index.go](https://app.codecov.io/gh/apache/skywalking-banyandb/pull/272?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFueWFuZC9tZXRhZGF0YS9zY2hlbWEvaW5kZXguZ28=) | `71.07% <0.00%> (-3.71%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-banyandb] hailin0 commented on pull request #272: Fix resource corrupts caused by update indexRule operation
Posted by "hailin0 (via GitHub)" <gi...@apache.org>.
hailin0 commented on PR #272:
URL: https://github.com/apache/skywalking-banyandb/pull/272#issuecomment-1538666687
> The patch is good for me. Can you please introduce a test case in `etcd_test.go` to cover the given scenario?
@hanahmily fixed, please help to recheck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org