[GitHub] [flink] QiLuo-BD commented on issue #7186: [FLINK-10941] Keep slots which contain unconsumed result partitions

[GitBox <gi...@apache.org>]

QiLuo-BD commented on issue #7186: [FLINK-10941] Keep slots which contain unconsumed result partitions
URL: https://github.com/apache/flink/pull/7186#issuecomment-470466442
 
 
   Hi @@azagrebin <https://github.com/azagrebin>,
   
   Thank you for help reviewing this! I agree that isClosed would be more clear than isReleased. But as @zhijiang pointed out that a new ShuffleService will be introduced to solve this issue in later version. Do you think this PR should still be updated & merged?
   
   Regards,
   Qi
   
   > On Mar 5, 2019, at 6:58 PM, azagrebin <no...@github.com> wrote:
   > 
   > @zhijiangW <https://github.com/zhijiangW>
   > I agree we need to revisit this topic after shuffle refactoring
   > 
   > @QiLuo-BD <https://github.com/QiLuo-BD>
   > What do you think if we keep releasing of partitions as it is now but add a separate isClosed flag to subpartition/partition and use it instead of isReleased?
   > The PartitionRequestQueue.close and PartitionRequestQueue.channelInactive could notify read view and subsequently subpartition/partition that it is closed. The task/slot could use partition.isClosed flag instead of isReeleased to report to resource manager that task executor can be released the same way as it is now in PR.
   > 
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub <https://github.com/apache/flink/pull/7186#issuecomment-469636966>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ArUS8zHlq6JS0hW1ZPdJiFp-FRHXClEGks5vTk3cgaJpZM4Y3THW>.
   > 
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services