You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Ram Sharma (JIRA)" <ji...@apache.org> on 2010/05/17 09:00:57 UTC

[jira] Created: (SHINDIG-1332) wrong replacement in FileContainer

wrong replacement in FileContainer 
-----------------------------------

                 Key: SHINDIG-1332
                 URL: https://issues.apache.org/jira/browse/SHINDIG-1332
             Project: Shindig
          Issue Type: Bug
            Reporter: Ram Sharma


/php/src/gadgets/servlet/FileServlet.php is doing replacement with incorrect string (url)

$file = str_replace(Config::get('web_prefix') . '/gadgets/files/', '', $_SERVER["REQUEST_URI"]);

it should be like this:

$file = str_replace(Config::get('web_prefix'), '', $_SERVER["REQUEST_URI"]);

as due to some changes in php/index.php 
$servletMap does not contain '/gadgets/files/' any more.

Patch is attached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-1332) wrong replacement in FileContainer

Posted by "Ram Sharma (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ram Sharma updated SHINDIG-1332:
--------------------------------

    Affects Version/s: 1.0.1
        Fix Version/s: 1.0.1
          Component/s: PHP

> wrong replacement in FileContainer 
> -----------------------------------
>
>                 Key: SHINDIG-1332
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1332
>             Project: Shindig
>          Issue Type: Bug
>          Components: PHP
>    Affects Versions: 1.0.1
>            Reporter: Ram Sharma
>             Fix For: 1.0.1
>
>
> /php/src/gadgets/servlet/FileServlet.php is doing replacement with incorrect string (url)
> $file = str_replace(Config::get('web_prefix') . '/gadgets/files/', '', $_SERVER["REQUEST_URI"]);
> it should be like this:
> $file = str_replace(Config::get('web_prefix'), '', $_SERVER["REQUEST_URI"]);
> as due to some changes in php/index.php 
> $servletMap does not contain '/gadgets/files/' any more.
> Patch is attached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-1332) wrong replacement in FileContainer

Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Lindner updated SHINDIG-1332:
----------------------------------

    Fix Version/s: 1.0.2
                       (was: 1.0.1)

> wrong replacement in FileContainer 
> -----------------------------------
>
>                 Key: SHINDIG-1332
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1332
>             Project: Shindig
>          Issue Type: Bug
>          Components: PHP
>    Affects Versions: 1.0.1
>            Reporter: Ram Sharma
>             Fix For: 1.0.2
>
>         Attachments: diff.patch
>
>
> /php/src/gadgets/servlet/FileServlet.php is doing replacement with incorrect string (url)
> $file = str_replace(Config::get('web_prefix') . '/gadgets/files/', '', $_SERVER["REQUEST_URI"]);
> it should be like this:
> $file = str_replace(Config::get('web_prefix'), '', $_SERVER["REQUEST_URI"]);
> as due to some changes in php/index.php 
> $servletMap does not contain '/gadgets/files/' any more.
> Patch is attached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-1332) wrong replacement in FileContainer

Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Lindner updated SHINDIG-1332:
----------------------------------

        Fix Version/s: 2.0.0-RC1
                           (was: 1.0.2)
    Affects Version/s: 2.0.0-RC1
                           (was: 1.0.1)

> wrong replacement in FileContainer 
> -----------------------------------
>
>                 Key: SHINDIG-1332
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1332
>             Project: Shindig
>          Issue Type: Bug
>          Components: PHP
>    Affects Versions: 2.0.0-RC1
>            Reporter: Ram Sharma
>             Fix For: 2.0.0-RC1
>
>         Attachments: diff.patch
>
>
> /php/src/gadgets/servlet/FileServlet.php is doing replacement with incorrect string (url)
> $file = str_replace(Config::get('web_prefix') . '/gadgets/files/', '', $_SERVER["REQUEST_URI"]);
> it should be like this:
> $file = str_replace(Config::get('web_prefix'), '', $_SERVER["REQUEST_URI"]);
> as due to some changes in php/index.php 
> $servletMap does not contain '/gadgets/files/' any more.
> Patch is attached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SHINDIG-1332) wrong replacement in FileContainer

Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Paul Lindner resolved SHINDIG-1332.
-----------------------------------

    Resolution: Fixed

Patch applied -- thanks!

> wrong replacement in FileContainer 
> -----------------------------------
>
>                 Key: SHINDIG-1332
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1332
>             Project: Shindig
>          Issue Type: Bug
>          Components: PHP
>    Affects Versions: 2.0.0-RC1
>            Reporter: Ram Sharma
>             Fix For: 2.0.0-RC1
>
>         Attachments: diff.patch
>
>
> /php/src/gadgets/servlet/FileServlet.php is doing replacement with incorrect string (url)
> $file = str_replace(Config::get('web_prefix') . '/gadgets/files/', '', $_SERVER["REQUEST_URI"]);
> it should be like this:
> $file = str_replace(Config::get('web_prefix'), '', $_SERVER["REQUEST_URI"]);
> as due to some changes in php/index.php 
> $servletMap does not contain '/gadgets/files/' any more.
> Patch is attached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-1332) wrong replacement in FileContainer

Posted by "Ram Sharma (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-1332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ram Sharma updated SHINDIG-1332:
--------------------------------

    Attachment: diff.patch

> wrong replacement in FileContainer 
> -----------------------------------
>
>                 Key: SHINDIG-1332
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1332
>             Project: Shindig
>          Issue Type: Bug
>          Components: PHP
>    Affects Versions: 1.0.1
>            Reporter: Ram Sharma
>             Fix For: 1.0.1
>
>         Attachments: diff.patch
>
>
> /php/src/gadgets/servlet/FileServlet.php is doing replacement with incorrect string (url)
> $file = str_replace(Config::get('web_prefix') . '/gadgets/files/', '', $_SERVER["REQUEST_URI"]);
> it should be like this:
> $file = str_replace(Config::get('web_prefix'), '', $_SERVER["REQUEST_URI"]);
> as due to some changes in php/index.php 
> $servletMap does not contain '/gadgets/files/' any more.
> Patch is attached.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.