You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Maik Richey (JIRA)" <ji...@codehaus.org> on 2010/10/02 21:36:32 UTC
[jira] Created: (MNG-4846) Profile activated accidentially
Profile activated accidentially
-------------------------------
Key: MNG-4846
URL: http://jira.codehaus.org/browse/MNG-4846
Project: Maven 2 & 3
Issue Type: Bug
Components: Profiles
Affects Versions: 2.2.1
Reporter: Maik Richey
Priority: Critical
When you define a profile activated like
{code}
...
<profiles>
<profile>
<id>someCase</id>
<activation>
<activeByDefault>false</activeByDefault>
<property>
<name>somePropertyName</name>
<value>!Value</value>
</property>
</activation>
...
</profile>
</profiles>
...
{code}
this profile will also be activated when no property/profile is defined on the command line. I expected that profile beeing activated only when you supply -DsomePropertyName=NotTheValue.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Reopened: (MNG-4846) Profile activated accidentially
Posted by "Maik Richey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-4846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maik Richey reopened MNG-4846:
------------------------------
see my last comment
> Profile activated accidentially
> -------------------------------
>
> Key: MNG-4846
> URL: http://jira.codehaus.org/browse/MNG-4846
> Project: Maven 2 & 3
> Issue Type: Bug
> Components: Profiles
> Affects Versions: 2.2.1
> Reporter: Maik Richey
> Assignee: Benjamin Bentmann
> Priority: Critical
>
> When you define a profile activated like
> {code}
> ...
> <profiles>
> <profile>
> <id>someCase</id>
> <activation>
> <activeByDefault>false</activeByDefault>
> <property>
> <name>somePropertyName</name>
> <value>!Value</value>
> </property>
> </activation>
> ...
> </profile>
> </profiles>
> ...
> {code}
> this profile will also be activated when no property/profile is defined on the command line. I expected that profile beeing activated only when you supply -DsomePropertyName=NotTheValue.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MNG-4846) Profile activated accidentially
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-4846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Bentmann closed MNG-4846.
----------------------------------
Resolution: Not A Bug
Assignee: Benjamin Bentmann
This works as designed, since {{"Value".equals( System.getProperty( "somePropertyName" ) ) == false}}.
> Profile activated accidentially
> -------------------------------
>
> Key: MNG-4846
> URL: http://jira.codehaus.org/browse/MNG-4846
> Project: Maven 2 & 3
> Issue Type: Bug
> Components: Profiles
> Affects Versions: 2.2.1
> Reporter: Maik Richey
> Assignee: Benjamin Bentmann
> Priority: Critical
>
> When you define a profile activated like
> {code}
> ...
> <profiles>
> <profile>
> <id>someCase</id>
> <activation>
> <activeByDefault>false</activeByDefault>
> <property>
> <name>somePropertyName</name>
> <value>!Value</value>
> </property>
> </activation>
> ...
> </profile>
> </profiles>
> ...
> {code}
> this profile will also be activated when no property/profile is defined on the command line. I expected that profile beeing activated only when you supply -DsomePropertyName=NotTheValue.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Issue Comment Edited: (MNG-4846) Profile activated
accidentially
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-4846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=237370#action_237370 ]
Benjamin Bentmann edited comment on MNG-4846 at 10/4/10 5:30 AM:
-----------------------------------------------------------------
This works as designed, since {{"Value".equals( System.getProperty( "somePropertyName" ) ) == false}} when {{somePropertyName}} has not been specified.
was (Author: bentmann):
This works as designed, since {{"Value".equals( System.getProperty( "somePropertyName" ) ) == false}}.
> Profile activated accidentially
> -------------------------------
>
> Key: MNG-4846
> URL: http://jira.codehaus.org/browse/MNG-4846
> Project: Maven 2 & 3
> Issue Type: Bug
> Components: Profiles
> Affects Versions: 2.2.1
> Reporter: Maik Richey
> Assignee: Benjamin Bentmann
> Priority: Critical
>
> When you define a profile activated like
> {code}
> ...
> <profiles>
> <profile>
> <id>someCase</id>
> <activation>
> <activeByDefault>false</activeByDefault>
> <property>
> <name>somePropertyName</name>
> <value>!Value</value>
> </property>
> </activation>
> ...
> </profile>
> </profiles>
> ...
> {code}
> this profile will also be activated when no property/profile is defined on the command line. I expected that profile beeing activated only when you supply -DsomePropertyName=NotTheValue.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-4846) Profile activated accidentially
Posted by "Maik Richey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-4846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Maik Richey updated MNG-4846:
-----------------------------
Attachment: SystemPropertyProfileActivator.patch
Created and attached a patch for SystemPropertyProfileActivator covering the difference mentioned. Please check it and give some feedback.
> Profile activated accidentially
> -------------------------------
>
> Key: MNG-4846
> URL: http://jira.codehaus.org/browse/MNG-4846
> Project: Maven 2 & 3
> Issue Type: Bug
> Components: Profiles
> Affects Versions: 2.2.1
> Reporter: Maik Richey
> Assignee: Benjamin Bentmann
> Priority: Critical
> Attachments: SystemPropertyProfileActivator.patch
>
>
> When you define a profile activated like
> {code}
> ...
> <profiles>
> <profile>
> <id>someCase</id>
> <activation>
> <activeByDefault>false</activeByDefault>
> <property>
> <name>somePropertyName</name>
> <value>!Value</value>
> </property>
> </activation>
> ...
> </profile>
> </profiles>
> ...
> {code}
> this profile will also be activated when no property/profile is defined on the command line. I expected that profile beeing activated only when you supply -DsomePropertyName=NotTheValue.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-4846) Profile activated accidentially
Posted by "Maik Richey (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MNG-4846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=237373#action_237373 ]
Maik Richey commented on MNG-4846:
----------------------------------
But then there is no difference to
{code}
...
<activation>
<activeByDefault>false</activeByDefault>
<property>
<name>!somePropertyName</name>
</property>
</activation>
...
{code}
and make no sense for me.
By specifying <name>somePropertyName</name> I would expect that property being there but not having the value "Value". That makes the difference.
To be more precise:
What I would like to do is defining some properties as default. The same properties should be used when activating a profile by property "env" and the value "target". Different properties should be used - and are defined in another profile - when specifying the property "env" with a value other than "target" to activate that profile. So the only way, rather than creating a profile for each possible value, is the way I tried to manage it and that's the way how it should work in my opinion.
> Profile activated accidentially
> -------------------------------
>
> Key: MNG-4846
> URL: http://jira.codehaus.org/browse/MNG-4846
> Project: Maven 2 & 3
> Issue Type: Bug
> Components: Profiles
> Affects Versions: 2.2.1
> Reporter: Maik Richey
> Assignee: Benjamin Bentmann
> Priority: Critical
>
> When you define a profile activated like
> {code}
> ...
> <profiles>
> <profile>
> <id>someCase</id>
> <activation>
> <activeByDefault>false</activeByDefault>
> <property>
> <name>somePropertyName</name>
> <value>!Value</value>
> </property>
> </activation>
> ...
> </profile>
> </profiles>
> ...
> {code}
> this profile will also be activated when no property/profile is defined on the command line. I expected that profile beeing activated only when you supply -DsomePropertyName=NotTheValue.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira