You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/08/24 18:27:19 UTC
[GitHub] [tvm] yelite opened a new pull request, #12578: [CI] github_cc_reviewers: Catch all exceptions so all reviewers can be processed
yelite opened a new pull request, #12578:
URL: https://github.com/apache/tvm/pull/12578
In a recent change, `github.post` throws `RuntimeError` instead of `HTTPError` when the requested reviewer isn't a project collaborator. This prevents other reviewers to be added to the PR, for example, https://github.com/apache/tvm/runs/8001367110?check_suite_focus=true.
This PR changes the caller to catch any exception so the execution won't be interrupted.
cc @driazati
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati commented on a diff in pull request #12578: [CI] github_cc_reviewers: Catch all exceptions so all reviewers can be processed
Posted by GitBox <gi...@apache.org>.
driazati commented on code in PR #12578:
URL: https://github.com/apache/tvm/pull/12578#discussion_r954161661
##########
tests/scripts/github_cc_reviewers.py:
##########
@@ -106,5 +107,8 @@ def find_reviewers(body: str) -> List[str]:
for reviewer in to_add:
try:
github.post(f"pulls/{number}/requested_reviewers", {"reviewers": [reviewer]})
- except error.HTTPError as e:
+ except KeyboardInterrupt:
+ sys.exit()
+ except Exception as e: # pylint: disable=broad-except
Review Comment:
nit to make pylint happy
```suggestion
except (RuntimeError, error.HTTPError) as e:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] driazati merged pull request #12578: [CI] github_cc_reviewers: Catch all exceptions so all reviewers can be processed
Posted by GitBox <gi...@apache.org>.
driazati merged PR #12578:
URL: https://github.com/apache/tvm/pull/12578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org