You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by "Julian Reschke (JIRA)" <ji...@apache.org> on 2012/06/06 18:44:23 UTC
[jira] [Created] (OAK-131) Session.save() silently discards pending
changes
Julian Reschke created OAK-131:
----------------------------------
Summary: Session.save() silently discards pending changes
Key: OAK-131
URL: https://issues.apache.org/jira/browse/OAK-131
Project: Jackrabbit Oak
Issue Type: Bug
Components: jcr
Reporter: Julian Reschke
SessionTest.testSaveInvalidStateException fails in OAK because save() implicitly calls refresh(true) (which is good), but refresh(true) discards pending changes (because the node being modified is gone in persistent storage).
See also mail thread starting here: http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201206.mbox/browser
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (OAK-131) Session.save() silently discards
pending changes
Posted by "Michael Dürig (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Dürig resolved OAK-131.
-------------------------------
Resolution: Fixed
Fix Version/s: 0.3
Assignee: Michael Dürig
All dependencies are fixed at revision 1350287 which also fixes this issue.
> Session.save() silently discards pending changes
> ------------------------------------------------
>
> Key: OAK-131
> URL: https://issues.apache.org/jira/browse/OAK-131
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: jcr
> Reporter: Julian Reschke
> Assignee: Michael Dürig
> Fix For: 0.3
>
>
> SessionTest.testSaveInvalidStateException fails in OAK because save() implicitly calls refresh(true) (which is good), but refresh(true) discards pending changes (because the node being modified is gone in persistent storage).
> See also mail thread starting here: http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201206.mbox/browser
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OAK-131) Session.save() silently discards
pending changes
Posted by "Julian Reschke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OAK-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290263#comment-13290263 ]
Julian Reschke commented on OAK-131:
------------------------------------
Jukka's proposal (see http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201206.mbox/%3CCAOFYJNY4DgwpBPrxDp71t2vsMyOt3+jwmeq2=qWFPAy+Fre6qQ@mail.gmail.com%3E):
"Perhaps we should replace such cases with conflict markers that
prevent the transient space from being resolved (for example with a
commit hook that prevents such markers from being present in commit).
Only if the session then explicitly removes or re-adds the modified
subtree, thus clearing the conflict marker, can the save succeed."
> Session.save() silently discards pending changes
> ------------------------------------------------
>
> Key: OAK-131
> URL: https://issues.apache.org/jira/browse/OAK-131
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: jcr
> Reporter: Julian Reschke
>
> SessionTest.testSaveInvalidStateException fails in OAK because save() implicitly calls refresh(true) (which is good), but refresh(true) discards pending changes (because the node being modified is gone in persistent storage).
> See also mail thread starting here: http://mail-archives.apache.org/mod_mbox/jackrabbit-oak-dev/201206.mbox/browser
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira