[GitHub] [arrow-ballista] andygrove commented on a diff in pull request #658: Cluster state refactor Part 2

["andygrove (via GitHub)" <gi...@apache.org>]

andygrove commented on code in PR #658:
URL: https://github.com/apache/arrow-ballista/pull/658#discussion_r1102847694


##########
ballista/scheduler/src/bin/main.rs:
##########
@@ -117,10 +100,13 @@ async fn main() -> Result<()> {
             .init();
     }
 
-    let addr = format!("{bind_host}:{port}");
+    let addr = format!("{}:{}", opt.bind_host, opt.bind_port);
     let addr = addr.parse()?;
 
     let config = SchedulerConfig {
+        namespace: opt.namespace,
+        external_host: opt.external_host,

Review Comment:
   It looks like this PR drops `bind_host`? That can be different from `external_host`, so I'm not sure we can do that.
   
   Or maybe that is handled somewhere else in this PR and I haven't seen it yet?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org