You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/09 01:36:36 UTC
[GitHub] [airflow] codecov-io commented on issue #6749: [AIRFLOW-6193] Do
not use asserts in Airflow main code
codecov-io commented on issue #6749: [AIRFLOW-6193] Do not use asserts in Airflow main code
URL: https://github.com/apache/airflow/pull/6749#issuecomment-563026474
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6749?src=pr&el=h1) Report
> Merging [#6749](https://codecov.io/gh/apache/airflow/pull/6749?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/803a87f2b2b564b3e8784de305f5bb4e9578e578?src=pr&el=desc) will **decrease** coverage by `0.48%`.
> The diff coverage is `38.9%`.
[](https://codecov.io/gh/apache/airflow/pull/6749?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6749 +/- ##
==========================================
- Coverage 84.83% 84.35% -0.49%
==========================================
Files 669 669
Lines 37833 38373 +540
==========================================
+ Hits 32097 32369 +272
- Misses 5736 6004 +268
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6749?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/example\_dags/example\_xcom.py](https://codecov.io/gh/apache/airflow/pull/6749/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvZXhhbXBsZV94Y29tLnB5) | `51.72% <0%> (-10.78%)` | :arrow_down: |
| [...ontrib/example\_dags/example\_kubernetes\_executor.py](https://codecov.io/gh/apache/airflow/pull/6749/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2V4YW1wbGVfZGFncy9leGFtcGxlX2t1YmVybmV0ZXNfZXhlY3V0b3IucHk=) | `80.95% <0%> (-4.05%)` | :arrow_down: |
| [airflow/executors/executor\_loader.py](https://codecov.io/gh/apache/airflow/pull/6749/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvZXhlY3V0b3JfbG9hZGVyLnB5) | `63.04% <0%> (-2.87%)` | :arrow_down: |
| [airflow/executors/dask\_executor.py](https://codecov.io/gh/apache/airflow/pull/6749/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMvZGFza19leGVjdXRvci5weQ==) | `5.88% <0%> (-0.9%)` | :arrow_down: |
| [...example\_dags/example\_kubernetes\_executor\_config.py](https://codecov.io/gh/apache/airflow/pull/6749/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2V4YW1wbGVfZGFncy9leGFtcGxlX2t1YmVybmV0ZXNfZXhlY3V0b3JfY29uZmlnLnB5) | `72.22% <0%> (-4.25%)` | :arrow_down: |
| [airflow/gcp/operators/gcs.py](https://codecov.io/gh/apache/airflow/pull/6749/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3Avb3BlcmF0b3JzL2djcy5weQ==) | `86.22% <100%> (+0.08%)` | :arrow_up: |
| [...irflow/gcp/hooks/cloud\_storage\_transfer\_service.py](https://codecov.io/gh/apache/airflow/pull/6749/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvY2xvdWRfc3RvcmFnZV90cmFuc2Zlcl9zZXJ2aWNlLnB5) | `89.34% <25%> (-2.17%)` | :arrow_down: |
| [airflow/executors/kubernetes\_executor.py](https://codecov.io/gh/apache/airflow/pull/6749/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGVjdXRvcnMva3ViZXJuZXRlc19leGVjdXRvci5weQ==) | `58.16% <30%> (-1.88%)` | :arrow_down: |
| [airflow/gcp/hooks/dataflow.py](https://codecov.io/gh/apache/airflow/pull/6749/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvZGF0YWZsb3cucHk=) | `89.28% <33.33%> (-2.18%)` | :arrow_down: |
| [airflow/gcp/hooks/bigquery\_dts.py](https://codecov.io/gh/apache/airflow/pull/6749/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvaG9va3MvYmlncXVlcnlfZHRzLnB5) | `80.64% <37.5%> (-5.57%)` | :arrow_down: |
| ... and [28 more](https://codecov.io/gh/apache/airflow/pull/6749/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6749?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6749?src=pr&el=footer). Last update [803a87f...81f633f](https://codecov.io/gh/apache/airflow/pull/6749?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services