You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "mryan1539 (via GitHub)" <gi...@apache.org> on 2024/05/08 21:51:41 UTC
[PR] Fix signal handling setup. [commons-daemon]
mryan1539 opened a new pull request, #166:
URL: https://github.com/apache/commons-daemon/pull/166
The signal handler was being assigned to the sa_handler member of the sigaction struct, which is incorrect; it should be assigned to the sa_sigaction member. The sa_handler is only for using the default handler or ignoring the signal. This worked only because the two fields are genrally a union, but new enough compilers will flag this as an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix signal handling setup. [commons-daemon]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #166:
URL: https://github.com/apache/commons-daemon/pull/166#issuecomment-2109515004
Integrated into #170 and attribution set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix signal handling setup. [commons-daemon]
Posted by "markt-asf (via GitHub)" <gi...@apache.org>.
markt-asf commented on PR #166:
URL: https://github.com/apache/commons-daemon/pull/166#issuecomment-2111939340
This PR introduces a new compilation error rather than fixing the existing one. It changes line 904 and it should be changing line 1311.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix signal handling setup. [commons-daemon]
Posted by "markt-asf (via GitHub)" <gi...@apache.org>.
markt-asf closed pull request #166: Fix signal handling setup.
URL: https://github.com/apache/commons-daemon/pull/166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org