You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2020/02/23 15:48:48 UTC
[GitHub] [logging-log4j2] MariusVolkhart opened a new pull request #343:
Conditionally perform status logging calculations in PluginRegistry
MariusVolkhart opened a new pull request #343: Conditionally perform status logging calculations in PluginRegistry
URL: https://github.com/apache/logging-log4j2/pull/343
Debug status logging is typically disabled, but formatting calculations were performed regardless.
Moving the formatting logic inside of a conditional reduces the startup time of applications. The reduction is mostly attributable to the fact that the class initialization of DecimalFormat is non-trivial for the JVM, as it loads a variety of formatting information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [logging-log4j2] rgoers closed pull request #343: Conditionally
perform status logging calculations in PluginRegistry
Posted by GitBox <gi...@apache.org>.
rgoers closed pull request #343: Conditionally perform status logging calculations in PluginRegistry
URL: https://github.com/apache/logging-log4j2/pull/343
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [logging-log4j2] rgoers commented on issue #343: Conditionally
perform status logging calculations in PluginRegistry
Posted by GitBox <gi...@apache.org>.
rgoers commented on issue #343: Conditionally perform status logging calculations in PluginRegistry
URL: https://github.com/apache/logging-log4j2/pull/343#issuecomment-590100716
I have applied a version of this that uses lambdas. Thanks for the good work!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [logging-log4j2] rgoers commented on a change in pull request #343:
Conditionally perform status logging calculations in PluginRegistry
Posted by GitBox <gi...@apache.org>.
rgoers commented on a change in pull request #343: Conditionally perform status logging calculations in PluginRegistry
URL: https://github.com/apache/logging-log4j2/pull/343#discussion_r383025858
##########
File path: log4j-plugins/src/main/java/org/apache/logging/log4j/plugins/util/PluginRegistry.java
##########
@@ -320,10 +326,12 @@ public void loadPlugins(ClassLoader classLoader, Map<String, List<PluginType<?>>
}
final long endTime = System.nanoTime();
Review comment:
This is a good idea but it makes more sense to me to have the whole message generated as a lambda. Working on modifying it to do that now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [logging-log4j2] carterkozak commented on a change in pull request
#343: Conditionally perform status logging calculations in PluginRegistry
Posted by GitBox <gi...@apache.org>.
carterkozak commented on a change in pull request #343: Conditionally perform status logging calculations in PluginRegistry
URL: https://github.com/apache/logging-log4j2/pull/343#discussion_r383015802
##########
File path: log4j-plugins/src/main/java/org/apache/logging/log4j/plugins/util/PluginRegistry.java
##########
@@ -320,10 +326,12 @@ public void loadPlugins(ClassLoader classLoader, Map<String, List<PluginType<?>>
}
final long endTime = System.nanoTime();
Review comment:
Can we move these nanoTime invocations into the conditional as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services