You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/11/19 03:10:07 UTC

[GitHub] [iotdb] RYH61 opened a new pull request, #8054: [IOTDB-4993] Rename the storage group of permissions to database

RYH61 opened a new pull request, #8054:
URL: https://github.com/apache/iotdb/pull/8054

   SET_STORAGE_GROUP | DELETE_STORAGE_GROUP 
   to
   CREATE_DATABASE | DELETE_DATABASE


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] RYH61 commented on pull request #8054: [IOTDB-4993] Rename the storage group of permissions to database

Posted by GitBox <gi...@apache.org>.
RYH61 commented on PR #8054:
URL: https://github.com/apache/iotdb/pull/8054#issuecomment-1320813275

   @qiaojialin @SpriCoder Please take a look at this pr
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] RYH61 commented on pull request #8054: [IOTDB-4993] Rename the storage group of permissions to database

Posted by GitBox <gi...@apache.org>.
RYH61 commented on PR #8054:
URL: https://github.com/apache/iotdb/pull/8054#issuecomment-1322871952

   > 
   
   ok


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] RYH61 commented on pull request #8054: [IOTDB-4993] Rename the storage group of permissions to database

Posted by GitBox <gi...@apache.org>.
RYH61 commented on PR #8054:
URL: https://github.com/apache/iotdb/pull/8054#issuecomment-1320771734

   @qiaojialin @SpriCoder Hi, Please review!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] qiaojialin merged pull request #8054: [IOTDB-4993] Rename the storage group of permissions to database

Posted by GitBox <gi...@apache.org>.
qiaojialin merged PR #8054:
URL: https://github.com/apache/iotdb/pull/8054


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] qiaojialin commented on pull request #8054: [IOTDB-4993] Rename the storage group of permissions to database

Posted by GitBox <gi...@apache.org>.
qiaojialin commented on PR #8054:
URL: https://github.com/apache/iotdb/pull/8054#issuecomment-1320782640

   Currently, sg  = database, so we need to maintain both


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] SpriCoder commented on pull request #8054: [IOTDB-4993] Rename the storage group of permissions to database

Posted by GitBox <gi...@apache.org>.
SpriCoder commented on PR #8054:
URL: https://github.com/apache/iotdb/pull/8054#issuecomment-1320772518

   @qiaojialin Please take a look whether we need to maintain `SET_STORAGE_GROUP | DELETE_STORAGE_GROUP|CREATE_DATABASE | DELETE_DATABASE` at the same time for compatibility.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org