You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/02/13 07:04:24 UTC

[GitHub] [calcite] danny0405 opened a new pull request #1802: [CALCITE-3792] Remove the generic type declaration of method

danny0405 opened a new pull request #1802: [CALCITE-3792] Remove the generic type declaration of method
URL: https://github.com/apache/calcite/pull/1802
 
 
   * The type inference of Scala code 'val mq = cluster.getMetadataQuery'
   is failed if we have that generic type declaration for the Java method
   * After this change, we need a explicit cast for RelMetadataQuery
   sub-class
   * Fix the RelMetadataTest to reset the RelMetadataQuery instance as
   default after a test
   * Also rename RelOptCluster#withHintStrategies to setHintStrategies
   because it does not really return a new copy

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [calcite] danny0405 commented on issue #1802: [CALCITE-3792] Remove the generic type declaration of method

Posted by GitBox <gi...@apache.org>.
danny0405 commented on issue #1802: [CALCITE-3792] Remove the generic type declaration of method
URL: https://github.com/apache/calcite/pull/1802#issuecomment-585604743
 
 
   The tests are already there ~

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [calcite] vlsi commented on issue #1802: [CALCITE-3792] Remove the generic type declaration of method

Posted by GitBox <gi...@apache.org>.
vlsi commented on issue #1802: [CALCITE-3792] Remove the generic type declaration of method
URL: https://github.com/apache/calcite/pull/1802#issuecomment-585609278
 
 
   Suppose someone would make another improvement like "adding a generic declaration".
   It would improve Java code.
   
   The changes (not just bugfixes) should be accompanied with tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [calcite] danny0405 merged pull request #1802: [CALCITE-3792] Remove the generic type declaration of method

Posted by GitBox <gi...@apache.org>.
danny0405 merged pull request #1802: [CALCITE-3792] Remove the generic type declaration of method
URL: https://github.com/apache/calcite/pull/1802
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [calcite] danny0405 commented on issue #1802: [CALCITE-3792] Remove the generic type declaration of method

Posted by GitBox <gi...@apache.org>.
danny0405 commented on issue #1802: [CALCITE-3792] Remove the generic type declaration of method
URL: https://github.com/apache/calcite/pull/1802#issuecomment-585612807
 
 
   Sorry, i didn't agree with that, the change to Java code is with this patch is minor and nothing compared to the Scala.
   
   This interface is introduced by me in version 1.22 so it does not expect to break anything.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [calcite] danny0405 commented on issue #1802: [CALCITE-3792] Remove the generic type declaration of method

Posted by GitBox <gi...@apache.org>.
danny0405 commented on issue #1802: [CALCITE-3792] Remove the generic type declaration of method
URL: https://github.com/apache/calcite/pull/1802#issuecomment-585608122
 
 
   This is not a bug, it is an improvement. No code would fail without this patch.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [calcite] danny0405 edited a comment on issue #1802: [CALCITE-3792] Remove the generic type declaration of method

Posted by GitBox <gi...@apache.org>.
danny0405 edited a comment on issue #1802: [CALCITE-3792] Remove the generic type declaration of method
URL: https://github.com/apache/calcite/pull/1802#issuecomment-585612807
 
 
   Sorry, i didn't agree with that, the change to Java code with this patch is minor and nothing compared to the Scala.
   
   This interface is introduced by me in version 1.22 so it does not expect to break anything.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [calcite] vlsi commented on issue #1802: [CALCITE-3792] Remove the generic type declaration of method

Posted by GitBox <gi...@apache.org>.
vlsi commented on issue #1802: [CALCITE-3792] Remove the generic type declaration of method
URL: https://github.com/apache/calcite/pull/1802#issuecomment-585607050
 
 
   AFAIK not a single test protects the code from reverting to its previous state.
   
   What I mean by tests is something that would **fail** if this PR is not merged.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services