You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by li...@apache.org on 2020/02/02 04:41:28 UTC

[dubbo] branch master updated: add comment for FutureAdapter, see #3979

This is an automated email from the ASF dual-hosted git repository.

liujun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo.git


The following commit(s) were added to refs/heads/master by this push:
     new 3bc4508  add comment for FutureAdapter, see #3979
3bc4508 is described below

commit 3bc4508d09756a40c85ddf0c62b94aaf5d957d58
Author: ken.lj <ke...@gmail.com>
AuthorDate: Sun Feb 2 12:36:28 2020 +0800

    add comment for FutureAdapter, see #3979
---
 .../main/java/org/apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java  | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java b/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java
index 1e119f1..2dcebda 100644
--- a/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java
+++ b/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/FutureAdapter.java
@@ -26,7 +26,9 @@ import java.util.concurrent.TimeUnit;
 import java.util.concurrent.TimeoutException;
 
 /**
- * FutureAdapter
+ * This is the type of the Future instance users get in an async call:
+ * 1. unwrap AppResponse in appResponseFuture and convert to plain biz result represented by FutureAdapter.
+ * 2. customized behaviors meaningful for RPC, for example, {@link #cancel(boolean)}
  */
 public class FutureAdapter<V> extends CompletableFuture<V> {