[GitHub] [airflow] dstandish commented on a change in pull request #6947: [AIRFLOW-XXX] add note warning that bash>4.0 is required for docs build

[GitBox <gi...@apache.org>]

dstandish commented on a change in pull request #6947: [AIRFLOW-XXX] add note warning that bash>4.0 is required for docs build
URL: https://github.com/apache/airflow/pull/6947#discussion_r361867695
 
 

 ##########
 File path: CONTRIBUTING.rst
 ##########
 @@ -95,6 +95,10 @@ To generate a local version:
     ./build.sh
     ./start_doc_server.sh
 
+.. note::
+    The docs build script ``build.sh`` requires bash 4.0 or greater.
 
 Review comment:
   yeah i totally get the value of using breeze for everything ... and that's what i used initially... just when i noticed that there was a host script it seemed significantly faster than docker so that's what i started using.  i try to stay in virtualenv when i can.
   
   but yesterday when i moved to a new machine, i forgot that i needed to upgrade bash again and stumbled around for a while (googling how to install mapfile etc).  so that was the impetus for adding.
   
   but i defer to you on this completely -- whatever you think is best.  if you are getting rid of host build script soon then yeah probably makes makes sense not to bother.
   
   thanks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services