You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltaspike.apache.org by Gerhard Petracek <ge...@gmail.com> on 2014/02/18 13:23:01 UTC
[DISCUSS] move @Initialized and @Destroyed
hi @ all,
if we would move @Initialized and @Destroyed to ds-core, we could use them
for other parts as well (e.g. instead of @BeforeJsfRequest and
@AfterJsfRequest).
regards,
gerhard
Re: [DISCUSS] move @Initialized and @Destroyed
Posted by Gerhard Petracek <ge...@gmail.com>.
i'll refactor it tomorrow.
+ i'll also replace @Initialized in the data-module (there we have the same
as well).
regards,
gerhard
2014-02-19 8:03 GMT+01:00 Christian Kaltepoth <ch...@kaltepoth.de>:
> +1
>
>
> 2014-02-18 14:29 GMT+01:00 Thomas Andraschko <andraschko.thomas@gmail.com
> >:
>
> > sounds good!
> >
> >
> > 2014-02-18 14:19 GMT+01:00 Gerhard Petracek <gerhard.petracek@gmail.com
> >:
> >
> > > @ thomas:
> > >
> > > @Observes @BeforeJsfRequest FacesContext
> > > @Observes @AfterJsfRequest FacesContext
> > > ->
> > > @Observes @Initialized FacesContext
> > > @Observes @Destroyed FacesContext
> > >
> > > the implementation of @AfterJsfRequest fits to @Destroyed, but for
> > > @Initialized we might have to move the logic (to get a real
> > initialization
> > > event).
> > > if we would move it to DeltaSpikeFacesContextFactory the benefit is
> > > minimal, but there would be an overhead for resource-request and there
> is
> > > no active client-window at that point.
> > >
> > > regards,
> > > gerhard
> > >
> > >
> > >
> > > 2014-02-18 13:44 GMT+01:00 Mark Struberg <st...@yahoo.de>:
> > >
> > > > +1
> > > >
> > > > LieGrue,
> > > > strub
> > > >
> > > >
> > > >
> > > >
> > > >
> > > > On Tuesday, 18 February 2014, 13:27, Thomas Andraschko <
> > > > andraschko.thomas@gmail.com> wrote:
> > > >
> > > > +1
> > > > >I like such minor improvements and finalize such stuff :)
> > > > >
> > > > >Whats the replacements for @After/BeforeJsfRequest then?
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >2014-02-18 13:23 GMT+01:00 Gerhard Petracek <
> > gerhard.petracek@gmail.com
> > > >:
> > > > >
> > > > >> hi @ all,
> > > > >>
> > > > >> if we would move @Initialized and @Destroyed to ds-core, we could
> > use
> > > > them
> > > > >> for other parts as well (e.g. instead of @BeforeJsfRequest and
> > > > >> @AfterJsfRequest).
> > > > >>
> > > > >> regards,
> > > > >> gerhard
> > > > >>
> > > > >
> > > > >
> > > > >
> > > >
> > >
> >
>
>
>
> --
> Christian Kaltepoth
> Blog: http://blog.kaltepoth.de/
> Twitter: http://twitter.com/chkal
> GitHub: https://github.com/chkal
>
Re: [DISCUSS] move @Initialized and @Destroyed
Posted by Thomas Hug <th...@gmail.com>.
Great, thnx! AFAIR it's only used in the QueryHandler in the data module.
On Wed, Feb 19, 2014 at 10:13 AM, Gerhard Petracek <
gerhard.petracek@gmail.com> wrote:
> i'll refactor it tomorrow.
> + i'll also replace @Initialized in the data-module (there we have the same
> as well).
>
> regards,
> gerhard
>
>
>
> 2014-02-19 8:03 GMT+01:00 Christian Kaltepoth <ch...@kaltepoth.de>:
>
> > +1
> >
> >
> > 2014-02-18 14:29 GMT+01:00 Thomas Andraschko <
> andraschko.thomas@gmail.com
> > >:
> >
> > > sounds good!
> > >
> > >
> > > 2014-02-18 14:19 GMT+01:00 Gerhard Petracek <
> gerhard.petracek@gmail.com
> > >:
> > >
> > > > @ thomas:
> > > >
> > > > @Observes @BeforeJsfRequest FacesContext
> > > > @Observes @AfterJsfRequest FacesContext
> > > > ->
> > > > @Observes @Initialized FacesContext
> > > > @Observes @Destroyed FacesContext
> > > >
> > > > the implementation of @AfterJsfRequest fits to @Destroyed, but for
> > > > @Initialized we might have to move the logic (to get a real
> > > initialization
> > > > event).
> > > > if we would move it to DeltaSpikeFacesContextFactory the benefit is
> > > > minimal, but there would be an overhead for resource-request and
> there
> > is
> > > > no active client-window at that point.
> > > >
> > > > regards,
> > > > gerhard
> > > >
> > > >
> > > >
> > > > 2014-02-18 13:44 GMT+01:00 Mark Struberg <st...@yahoo.de>:
> > > >
> > > > > +1
> > > > >
> > > > > LieGrue,
> > > > > strub
> > > > >
> > > > >
> > > > >
> > > > >
> > > > >
> > > > > On Tuesday, 18 February 2014, 13:27, Thomas Andraschko <
> > > > > andraschko.thomas@gmail.com> wrote:
> > > > >
> > > > > +1
> > > > > >I like such minor improvements and finalize such stuff :)
> > > > > >
> > > > > >Whats the replacements for @After/BeforeJsfRequest then?
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > >2014-02-18 13:23 GMT+01:00 Gerhard Petracek <
> > > gerhard.petracek@gmail.com
> > > > >:
> > > > > >
> > > > > >> hi @ all,
> > > > > >>
> > > > > >> if we would move @Initialized and @Destroyed to ds-core, we
> could
> > > use
> > > > > them
> > > > > >> for other parts as well (e.g. instead of @BeforeJsfRequest and
> > > > > >> @AfterJsfRequest).
> > > > > >>
> > > > > >> regards,
> > > > > >> gerhard
> > > > > >>
> > > > > >
> > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> >
> >
> > --
> > Christian Kaltepoth
> > Blog: http://blog.kaltepoth.de/
> > Twitter: http://twitter.com/chkal
> > GitHub: https://github.com/chkal
> >
>
Re: [DISCUSS] move @Initialized and @Destroyed
Posted by Christian Kaltepoth <ch...@kaltepoth.de>.
+1
2014-02-18 14:29 GMT+01:00 Thomas Andraschko <an...@gmail.com>:
> sounds good!
>
>
> 2014-02-18 14:19 GMT+01:00 Gerhard Petracek <ge...@gmail.com>:
>
> > @ thomas:
> >
> > @Observes @BeforeJsfRequest FacesContext
> > @Observes @AfterJsfRequest FacesContext
> > ->
> > @Observes @Initialized FacesContext
> > @Observes @Destroyed FacesContext
> >
> > the implementation of @AfterJsfRequest fits to @Destroyed, but for
> > @Initialized we might have to move the logic (to get a real
> initialization
> > event).
> > if we would move it to DeltaSpikeFacesContextFactory the benefit is
> > minimal, but there would be an overhead for resource-request and there is
> > no active client-window at that point.
> >
> > regards,
> > gerhard
> >
> >
> >
> > 2014-02-18 13:44 GMT+01:00 Mark Struberg <st...@yahoo.de>:
> >
> > > +1
> > >
> > > LieGrue,
> > > strub
> > >
> > >
> > >
> > >
> > >
> > > On Tuesday, 18 February 2014, 13:27, Thomas Andraschko <
> > > andraschko.thomas@gmail.com> wrote:
> > >
> > > +1
> > > >I like such minor improvements and finalize such stuff :)
> > > >
> > > >Whats the replacements for @After/BeforeJsfRequest then?
> > > >
> > > >
> > > >
> > > >
> > > >2014-02-18 13:23 GMT+01:00 Gerhard Petracek <
> gerhard.petracek@gmail.com
> > >:
> > > >
> > > >> hi @ all,
> > > >>
> > > >> if we would move @Initialized and @Destroyed to ds-core, we could
> use
> > > them
> > > >> for other parts as well (e.g. instead of @BeforeJsfRequest and
> > > >> @AfterJsfRequest).
> > > >>
> > > >> regards,
> > > >> gerhard
> > > >>
> > > >
> > > >
> > > >
> > >
> >
>
--
Christian Kaltepoth
Blog: http://blog.kaltepoth.de/
Twitter: http://twitter.com/chkal
GitHub: https://github.com/chkal
Re: [DISCUSS] move @Initialized and @Destroyed
Posted by Thomas Andraschko <an...@gmail.com>.
sounds good!
2014-02-18 14:19 GMT+01:00 Gerhard Petracek <ge...@gmail.com>:
> @ thomas:
>
> @Observes @BeforeJsfRequest FacesContext
> @Observes @AfterJsfRequest FacesContext
> ->
> @Observes @Initialized FacesContext
> @Observes @Destroyed FacesContext
>
> the implementation of @AfterJsfRequest fits to @Destroyed, but for
> @Initialized we might have to move the logic (to get a real initialization
> event).
> if we would move it to DeltaSpikeFacesContextFactory the benefit is
> minimal, but there would be an overhead for resource-request and there is
> no active client-window at that point.
>
> regards,
> gerhard
>
>
>
> 2014-02-18 13:44 GMT+01:00 Mark Struberg <st...@yahoo.de>:
>
> > +1
> >
> > LieGrue,
> > strub
> >
> >
> >
> >
> >
> > On Tuesday, 18 February 2014, 13:27, Thomas Andraschko <
> > andraschko.thomas@gmail.com> wrote:
> >
> > +1
> > >I like such minor improvements and finalize such stuff :)
> > >
> > >Whats the replacements for @After/BeforeJsfRequest then?
> > >
> > >
> > >
> > >
> > >2014-02-18 13:23 GMT+01:00 Gerhard Petracek <gerhard.petracek@gmail.com
> >:
> > >
> > >> hi @ all,
> > >>
> > >> if we would move @Initialized and @Destroyed to ds-core, we could use
> > them
> > >> for other parts as well (e.g. instead of @BeforeJsfRequest and
> > >> @AfterJsfRequest).
> > >>
> > >> regards,
> > >> gerhard
> > >>
> > >
> > >
> > >
> >
>
Re: [DISCUSS] move @Initialized and @Destroyed
Posted by Gerhard Petracek <ge...@gmail.com>.
@ thomas:
@Observes @BeforeJsfRequest FacesContext
@Observes @AfterJsfRequest FacesContext
->
@Observes @Initialized FacesContext
@Observes @Destroyed FacesContext
the implementation of @AfterJsfRequest fits to @Destroyed, but for
@Initialized we might have to move the logic (to get a real initialization
event).
if we would move it to DeltaSpikeFacesContextFactory the benefit is
minimal, but there would be an overhead for resource-request and there is
no active client-window at that point.
regards,
gerhard
2014-02-18 13:44 GMT+01:00 Mark Struberg <st...@yahoo.de>:
> +1
>
> LieGrue,
> strub
>
>
>
>
>
> On Tuesday, 18 February 2014, 13:27, Thomas Andraschko <
> andraschko.thomas@gmail.com> wrote:
>
> +1
> >I like such minor improvements and finalize such stuff :)
> >
> >Whats the replacements for @After/BeforeJsfRequest then?
> >
> >
> >
> >
> >2014-02-18 13:23 GMT+01:00 Gerhard Petracek <ge...@gmail.com>:
> >
> >> hi @ all,
> >>
> >> if we would move @Initialized and @Destroyed to ds-core, we could use
> them
> >> for other parts as well (e.g. instead of @BeforeJsfRequest and
> >> @AfterJsfRequest).
> >>
> >> regards,
> >> gerhard
> >>
> >
> >
> >
>
Re: [DISCUSS] move @Initialized and @Destroyed
Posted by Mark Struberg <st...@yahoo.de>.
+1
LieGrue,
strub
On Tuesday, 18 February 2014, 13:27, Thomas Andraschko <an...@gmail.com> wrote:
+1
>I like such minor improvements and finalize such stuff :)
>
>Whats the replacements for @After/BeforeJsfRequest then?
>
>
>
>
>2014-02-18 13:23 GMT+01:00 Gerhard Petracek <ge...@gmail.com>:
>
>> hi @ all,
>>
>> if we would move @Initialized and @Destroyed to ds-core, we could use them
>> for other parts as well (e.g. instead of @BeforeJsfRequest and
>> @AfterJsfRequest).
>>
>> regards,
>> gerhard
>>
>
>
>
Re: [DISCUSS] move @Initialized and @Destroyed
Posted by Thomas Andraschko <an...@gmail.com>.
+1
I like such minor improvements and finalize such stuff :)
Whats the replacements for @After/BeforeJsfRequest then?
2014-02-18 13:23 GMT+01:00 Gerhard Petracek <ge...@gmail.com>:
> hi @ all,
>
> if we would move @Initialized and @Destroyed to ds-core, we could use them
> for other parts as well (e.g. instead of @BeforeJsfRequest and
> @AfterJsfRequest).
>
> regards,
> gerhard
>