You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Marcel Reutegger (JIRA)" <ji...@apache.org> on 2017/06/14 07:48:00 UTC

[jira] [Commented] (OAK-6346) Set baseline plugin comparison version to 1.6.0

    [ https://issues.apache.org/jira/browse/OAK-6346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048809#comment-16048809 ] 

Marcel Reutegger commented on OAK-6346:
---------------------------------------

Do you consider this an interim solution or would this be permanent. What's the process to update this new base version as we approach a 1.8.0 release with a 1.8 branch if this is considered permanent?

IIUC this has some additional side effects. Adding new methods to a provider type over several unstable releases would no longer indicate a minor version bump after the first one. From stable releases POV this may even be desirable. I just want to point out this change in behaviour.

If we go with the patch, can you please add a comment to the oak-core artifactId configuration in oak-api pom.xml? This is far from obvious. Is this really the only tweak you had to do because of m18n? I understand many package were moved around and a number of new modules were introduced.

> Set baseline plugin comparison version to 1.6.0
> -----------------------------------------------
>
>                 Key: OAK-6346
>                 URL: https://issues.apache.org/jira/browse/OAK-6346
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: parent
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>             Fix For: 1.8
>
>         Attachments: OAK-6346-v1.patch
>
>
> The purpose of baseline plugin is to ensure that any change in api get reflected in exported version of the package. Currently the baseline plugin compares against the immediate previous version. 
> This causes issue with unstable branches where new features are being implemented and which evolve over few minor release on the trunk. In such cases its possible that a new method expose in 1.7.1 gets removed later in 1.7.2 (as happened in OAK-6337).
> It would be better to configure baseline plugin to check against releases from stable branch so that we can ensure that package versions are properly aligned against stable versions



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)