You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/18 08:39:55 UTC
[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #3095: ESP32: Allow a BSS section to reside in external memory
Ouss4 opened a new pull request #3095:
URL: https://github.com/apache/incubator-nuttx/pull/3095
## Summary
1. Add a bss section that can be locate in external memory.
2. Adapt the heap when the external memory bss section exists.
## Impact
New feature for ESP32. Disabled by default.
## Testing
ESP32 boards with external PSRAM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt merged pull request #3095: ESP32: Allow a BSS section to reside in external memory
Posted by GitBox <gi...@apache.org>.
yamt merged pull request #3095:
URL: https://github.com/apache/incubator-nuttx/pull/3095
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on a change in pull request #3095: ESP32: Allow a BSS section to reside in external memory
Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #3095:
URL: https://github.com/apache/incubator-nuttx/pull/3095#discussion_r597325178
##########
File path: arch/xtensa/src/common/xtensa_attr.h
##########
@@ -63,4 +69,10 @@
#define RTC_RODATA_ATTR __attribute__((section(".rtc.rodata")))
+/* Forces bss variable into external memory. */
Review comment:
what kind of data needs to be forced to be in spiram?
if its purpose is to save internal memory, i guess it's more useful to make it "allow to be in spiram", rather than force. ie. make `EXT_RAM_ATTR` no-op unless `CONFIG_XTENSA_EXTMEM_BSS` is enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #3095: ESP32: Allow a BSS section to reside in external memory
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on a change in pull request #3095:
URL: https://github.com/apache/incubator-nuttx/pull/3095#discussion_r597451568
##########
File path: arch/xtensa/src/common/xtensa_attr.h
##########
@@ -63,4 +69,10 @@
#define RTC_RODATA_ATTR __attribute__((section(".rtc.rodata")))
+/* Forces bss variable into external memory. */
Review comment:
The data that usually gets in SPIRAM are large bss data. Yes, the purpose is to save some internal memory.
I made EXT_RAM_ATTR a no-op when CONFIG_XTENSA_EXTMEM_BSS is not enabled and changed the "force" to "allow", although, I find that when we are using the attribute we are actually forcing the variable to reside in that section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #3095: ESP32: Allow a BSS section to reside in external memory
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #3095:
URL: https://github.com/apache/incubator-nuttx/pull/3095#issuecomment-804677874
@yamt can you please check again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org