You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/07/26 09:44:15 UTC

[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10998: [Feature-10983] [refactor] ResourcesController

SbloodyS commented on code in PR #10998:
URL: https://github.com/apache/dolphinscheduler/pull/10998#discussion_r929753760


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/BaseService.java:
##########
@@ -76,6 +76,14 @@ public interface BaseService {
      */
     void putMsg(Result<Object> result, Status status, Object... statusParams);
 
+    /**
+     * copy result msg from source to target
+     *
+     * @param        source source result
+     * @param        target target result
+     */
+    void copyMsg(Result source, Result target);
+

Review Comment:
   > @SbloodyS @caishunfeng so what i should do is delete copy method and use get/set ? right ?
   
   Yes.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org