[skywalking] branch master updated: Only count 5xx as error in Envoy ALS receiver (#7111)

[wu...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git


The following commit(s) were added to refs/heads/master by this push:
     new efcb396  Only count 5xx as error in Envoy ALS receiver (#7111)
efcb396 is described below

commit efcb396f7338265f0b1e05f1a512dcd65773c538
Author: Zhenxu <ke...@apache.org>
AuthorDate: Sat Jun 12 07:09:48 2021 +0800

    Only count 5xx as error in Envoy ALS receiver (#7111)
---
 CHANGES.md                                                              | 1 +
 .../oap/server/receiver/envoy/als/LogEntry2MetricsAdapter.java          | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/CHANGES.md b/CHANGES.md
index 9b28d50..670deab 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -13,6 +13,7 @@ Release Notes.
 #### OAP-Backend
 * Disable Spring sleuth meter analyzer by default.
 * Use MAL to calculate JVM metrics, remove OAL dependency.
+* Only count 5xx as error in Envoy ALS receiver.
 
 #### UI
 
diff --git a/oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/als/LogEntry2MetricsAdapter.java b/oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/als/LogEntry2MetricsAdapter.java
index 63da419..0f61b08 100644
--- a/oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/als/LogEntry2MetricsAdapter.java
+++ b/oap-server/server-receiver-plugin/envoy-metrics-receiver-plugin/src/main/java/org/apache/skywalking/oap/server/receiver/envoy/als/LogEntry2MetricsAdapter.java
@@ -96,7 +96,7 @@ public class LogEntry2MetricsAdapter {
         final String endpoint = endpoint();
         int responseCode = entry.getResponse().getResponseCode().getValue();
         responseCode = responseCode > 0 ? responseCode : 200;
-        final boolean status = responseCode >= 200 && responseCode < 400;
+        final boolean status = responseCode < 500;
         final Protocol protocol = requestProtocol(entry.getRequest());
         final String tlsMode = parseTLS(properties.getTlsProperties());
         final String internalErrorCode = parseInternalErrorCode(properties.getResponseFlags());