You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/07/27 21:44:17 UTC

[GitHub] [spark] ueshin opened a new pull request #33547: [SPARK-36310][PYTHON] Fix IndexOpsMixin.hasnans to use isnull().any()

ueshin opened a new pull request #33547:
URL: https://github.com/apache/spark/pull/33547


   ### What changes were proposed in this pull request?
   
   Fix `IndexOpsMixin.hasnans` to use `IndexOpsMixin.isnull().any()`.
   
   ### Why are the changes needed?
   
   `IndexOpsMixin.hasnans` has a potential issue to cause `a window function inside an aggregate function` error.
   Also it returns a wrong value when the `Series`/`Index` is empty.
   
   ```py
   >>> ps.Series([]).hasnans
   None
   ```
   
   whereas:
   
   ```py
   >>> pd.Series([]).hasnans
   False
   ```
   
   `IndexOpsMixin.any()` is safe for both cases.
   
   ### Does this PR introduce _any_ user-facing change?
   
   `IndexOpsMixin.hasnans` will return `False` when empty.
   
   ### How was this patch tested?
   
   Added some tests.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33547: [SPARK-36310][PYTHON] Fix IndexOpsMixin.hasnans to use isnull().any()

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33547:
URL: https://github.com/apache/spark/pull/33547#issuecomment-887939282


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46253/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #33547: [SPARK-36310][PYTHON] Fix IndexOpsMixin.hasnans to use isnull().any()

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33547:
URL: https://github.com/apache/spark/pull/33547#issuecomment-887918259


   Merged to master and branch-3.2.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33547: [SPARK-36310][PYTHON] Fix IndexOpsMixin.hasnans to use isnull().any()

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33547:
URL: https://github.com/apache/spark/pull/33547#issuecomment-887939282


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46253/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33547: [SPARK-36310][PYTHON] Fix IndexOpsMixin.hasnans to use isnull().any()

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33547:
URL: https://github.com/apache/spark/pull/33547#issuecomment-887875105


   **[Test build #141734 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141734/testReport)** for PR 33547 at commit [`e5f8df9`](https://github.com/apache/spark/commit/e5f8df9ac1bb45401b5a3865c0feb949226d26dc).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] xinrong-databricks edited a comment on pull request #33547: [SPARK-36310][PYTHON] Fix IndexOpsMixin.hasnans to use isnull().any()

Posted by GitBox <gi...@apache.org>.
xinrong-databricks edited a comment on pull request #33547:
URL: https://github.com/apache/spark/pull/33547#issuecomment-887882188


   LGTM, pending tests, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33547: [SPARK-36310][PYTHON] Fix IndexOpsMixin.hasnans to use isnull().any()

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33547:
URL: https://github.com/apache/spark/pull/33547#issuecomment-887897858






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33547: [SPARK-36310][PYTHON] Fix IndexOpsMixin.hasnans to use isnull().any()

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33547:
URL: https://github.com/apache/spark/pull/33547#issuecomment-887918950


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141740/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33547: [SPARK-36310][PYTHON] Fix IndexOpsMixin.hasnans to use isnull().any()

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33547:
URL: https://github.com/apache/spark/pull/33547#issuecomment-887918950


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141740/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33547: [SPARK-36310][PYTHON] Fix IndexOpsMixin.hasnans to use isnull().any()

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33547:
URL: https://github.com/apache/spark/pull/33547#issuecomment-887899857


   **[Test build #141740 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141740/testReport)** for PR 33547 at commit [`e5f8df9`](https://github.com/apache/spark/commit/e5f8df9ac1bb45401b5a3865c0feb949226d26dc).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] xinrong-databricks commented on pull request #33547: [SPARK-36310][PYTHON] Fix IndexOpsMixin.hasnans to use isnull().any()

Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on pull request #33547:
URL: https://github.com/apache/spark/pull/33547#issuecomment-887882188


   LGTM, pending tests


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33547: [SPARK-36310][PYTHON] Fix IndexOpsMixin.hasnans to use isnull().any()

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33547:
URL: https://github.com/apache/spark/pull/33547#issuecomment-887917552


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46253/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon closed pull request #33547: [SPARK-36310][PYTHON] Fix IndexOpsMixin.hasnans to use isnull().any()

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #33547:
URL: https://github.com/apache/spark/pull/33547


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33547: [SPARK-36310][PYTHON] Fix IndexOpsMixin.hasnans to use isnull().any()

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33547:
URL: https://github.com/apache/spark/pull/33547#issuecomment-887910136


   **[Test build #141740 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141740/testReport)** for PR 33547 at commit [`e5f8df9`](https://github.com/apache/spark/commit/e5f8df9ac1bb45401b5a3865c0feb949226d26dc).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33547: [SPARK-36310][PYTHON] Fix IndexOpsMixin.hasnans to use isnull().any()

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33547:
URL: https://github.com/apache/spark/pull/33547#issuecomment-887895545


   Kubernetes integration test unable to build dist.
   
   exiting with code: 1
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46247/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33547: [SPARK-36310][PYTHON] Fix IndexOpsMixin.hasnans to use isnull().any()

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33547:
URL: https://github.com/apache/spark/pull/33547#issuecomment-887875105


   **[Test build #141734 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141734/testReport)** for PR 33547 at commit [`e5f8df9`](https://github.com/apache/spark/commit/e5f8df9ac1bb45401b5a3865c0feb949226d26dc).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33547: [SPARK-36310][PYTHON] Fix IndexOpsMixin.hasnans to use isnull().any()

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33547:
URL: https://github.com/apache/spark/pull/33547#issuecomment-887899857


   **[Test build #141740 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141740/testReport)** for PR 33547 at commit [`e5f8df9`](https://github.com/apache/spark/commit/e5f8df9ac1bb45401b5a3865c0feb949226d26dc).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33547: [SPARK-36310][PYTHON] Fix IndexOpsMixin.hasnans to use isnull().any()

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33547:
URL: https://github.com/apache/spark/pull/33547#issuecomment-887897858






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] ueshin commented on pull request #33547: [SPARK-36310][PYTHON] Fix IndexOpsMixin.hasnans to use isnull().any()

Posted by GitBox <gi...@apache.org>.
ueshin commented on pull request #33547:
URL: https://github.com/apache/spark/pull/33547#issuecomment-887899156


   Jenkins, retest this please.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33547: [SPARK-36310][PYTHON] Fix IndexOpsMixin.hasnans to use isnull().any()

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33547:
URL: https://github.com/apache/spark/pull/33547#issuecomment-887883356


   **[Test build #141734 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141734/testReport)** for PR 33547 at commit [`e5f8df9`](https://github.com/apache/spark/commit/e5f8df9ac1bb45401b5a3865c0feb949226d26dc).
    * This patch **fails PySpark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] ueshin commented on pull request #33547: [SPARK-36310][PYTHON] Fix IndexOpsMixin.hasnans to use isnull().any()

Posted by GitBox <gi...@apache.org>.
ueshin commented on pull request #33547:
URL: https://github.com/apache/spark/pull/33547#issuecomment-887855263


   cc @xinrong-databricks @HyukjinKwon @itholic 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33547: [SPARK-36310][PYTHON] Fix IndexOpsMixin.hasnans to use isnull().any()

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33547:
URL: https://github.com/apache/spark/pull/33547#issuecomment-887928315


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46253/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org