[GitHub] [airflow] gmcrocetti commented on a diff in pull request #23791: Fix DataprocJobBaseOperator not compatible with TaskGroups

[GitBox <gi...@apache.org>]

gmcrocetti commented on code in PR #23791:
URL: https://github.com/apache/airflow/pull/23791#discussion_r876491696


##########
tests/providers/google/cloud/operators/test_dataproc.py:
##########
@@ -1204,8 +1204,9 @@ class TestDataProcHiveOperator(unittest.TestCase):
     query = "define sin HiveUDF('sin');"
     variables = {"key": "value"}
     job_id = "uuid_id"
+    job_name = "simple"
     job = {
-        "reference": {"project_id": GCP_PROJECT, "job_id": "{{task.task_id}}_{{ds_nodash}}_" + job_id},
+        "reference": {"project_id": GCP_PROJECT, "job_id": f"{job_name}_{job_id}"},

Review Comment:
   Adding the variable above `job_name` was the easiest solution I've found to avoid a considerable refactoring of the following tests. Any other suggestions are welcome



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org