You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Daniel Becker (Code Review)" <ge...@cloudera.org> on 2023/01/05 15:02:33 UTC
[Impala-ASF-CR](asf-site) IMPALA-11825: Doc update 4.2.0 breaks web search results
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19402
Change subject: IMPALA-11825: Doc update 4.2.0 breaks web search results
......................................................................
IMPALA-11825: Doc update 4.2.0 breaks web search results
We recently updated the upstream Impala docs in
https://gerrit.cloudera.org/#/c/19367/. The doc build system introduced
a new directory with CSS formatted html but also renamed the old 'html'
directory to 'plain-html'. The problem is that changing the directory
name from 'html' to 'plain-html' breaks web search results as they still
have the old links.
This change is a quick and dirty fix. It duplicates the 'asf-site-html'
directory as 'html' so the old web links continue to work. We should
come up with a clean solution in a follow-up change.
Change-Id: Iab1d5fe5e3be85f26aeeb24be9e0018935d2e424
---
A docs/build/html/css/commonltr.css
A docs/build/html/css/commonrtl.css
A docs/build/html/css/dita-ot-doc.css
A docs/build/html/images/impala_arch.jpeg
A docs/build/html/index.html
A docs/build/html/shared/ImpalaVariables.html
A docs/build/html/shared/impala_common.html
A docs/build/html/topics/impala_abort_on_error.html
A docs/build/html/topics/impala_adls.html
A docs/build/html/topics/impala_admin.html
A docs/build/html/topics/impala_admission.html
A docs/build/html/topics/impala_admission_config.html
A docs/build/html/topics/impala_aggregate_functions.html
A docs/build/html/topics/impala_aliases.html
A docs/build/html/topics/impala_allow_erasure_coded_files.html
A docs/build/html/topics/impala_allow_unsupported_formats.html
A docs/build/html/topics/impala_alter_database.html
A docs/build/html/topics/impala_alter_table.html
A docs/build/html/topics/impala_alter_view.html
A docs/build/html/topics/impala_analytic_functions.html
A docs/build/html/topics/impala_appx_count_distinct.html
A docs/build/html/topics/impala_appx_median.html
A docs/build/html/topics/impala_array.html
A docs/build/html/topics/impala_auditing.html
A docs/build/html/topics/impala_authentication.html
A docs/build/html/topics/impala_authorization.html
A docs/build/html/topics/impala_avg.html
A docs/build/html/topics/impala_avro.html
A docs/build/html/topics/impala_batch_size.html
A docs/build/html/topics/impala_bigint.html
A docs/build/html/topics/impala_bit_functions.html
A docs/build/html/topics/impala_boolean.html
A docs/build/html/topics/impala_breakpad.html
A docs/build/html/topics/impala_broadcast_bytes_limit.html
A docs/build/html/topics/impala_buffer_pool_limit.html
A docs/build/html/topics/impala_char.html
A docs/build/html/topics/impala_client.html
A docs/build/html/topics/impala_comment.html
A docs/build/html/topics/impala_comments.html
A docs/build/html/topics/impala_complex_types.html
A docs/build/html/topics/impala_components.html
A docs/build/html/topics/impala_compression_codec.html
A docs/build/html/topics/impala_compute_stats.html
A docs/build/html/topics/impala_compute_stats_min_sample_size.html
A docs/build/html/topics/impala_concepts.html
A docs/build/html/topics/impala_conditional_functions.html
A docs/build/html/topics/impala_config.html
A docs/build/html/topics/impala_config_options.html
A docs/build/html/topics/impala_config_performance.html
A docs/build/html/topics/impala_connecting.html
A docs/build/html/topics/impala_conversion_functions.html
A docs/build/html/topics/impala_count.html
A docs/build/html/topics/impala_create_database.html
A docs/build/html/topics/impala_create_function.html
A docs/build/html/topics/impala_create_role.html
A docs/build/html/topics/impala_create_table.html
A docs/build/html/topics/impala_create_view.html
A docs/build/html/topics/impala_custom_timezones.html
A docs/build/html/topics/impala_data_cache.html
A docs/build/html/topics/impala_databases.html
A docs/build/html/topics/impala_datatypes.html
A docs/build/html/topics/impala_date.html
A docs/build/html/topics/impala_datetime_functions.html
A docs/build/html/topics/impala_ddl.html
A docs/build/html/topics/impala_debug_action.html
A docs/build/html/topics/impala_decimal.html
A docs/build/html/topics/impala_decimal_v2.html
A docs/build/html/topics/impala_dedicated_coordinator.html
A docs/build/html/topics/impala_default_file_format.html
A docs/build/html/topics/impala_default_hints_insert_statement.html
A docs/build/html/topics/impala_default_join_distribution_mode.html
A docs/build/html/topics/impala_default_spillable_buffer_size.html
A docs/build/html/topics/impala_default_transactional_type.html
A docs/build/html/topics/impala_delegation.html
A docs/build/html/topics/impala_delete.html
A docs/build/html/topics/impala_delete_stats_in_truncate.html
A docs/build/html/topics/impala_describe.html
A docs/build/html/topics/impala_development.html
A docs/build/html/topics/impala_disable_codegen.html
A docs/build/html/topics/impala_disable_codegen_rows_threshold.html
A docs/build/html/topics/impala_disable_hbase_num_rows_estimate.html
A docs/build/html/topics/impala_disable_row_runtime_filtering.html
A docs/build/html/topics/impala_disable_streaming_preaggregations.html
A docs/build/html/topics/impala_disable_unsafe_spills.html
A docs/build/html/topics/impala_disk_space.html
A docs/build/html/topics/impala_distinct.html
A docs/build/html/topics/impala_dml.html
A docs/build/html/topics/impala_double.html
A docs/build/html/topics/impala_drop_database.html
A docs/build/html/topics/impala_drop_function.html
A docs/build/html/topics/impala_drop_role.html
A docs/build/html/topics/impala_drop_stats.html
A docs/build/html/topics/impala_drop_table.html
A docs/build/html/topics/impala_drop_view.html
A docs/build/html/topics/impala_enable_expr_rewrites.html
A docs/build/html/topics/impala_exec_single_node_rows_threshold.html
A docs/build/html/topics/impala_exec_time_limit_s.html
A docs/build/html/topics/impala_expand_complex_types.html
A docs/build/html/topics/impala_explain.html
A docs/build/html/topics/impala_explain_level.html
A docs/build/html/topics/impala_explain_plan.html
A docs/build/html/topics/impala_faq.html
A docs/build/html/topics/impala_fault_tolerance.html
A docs/build/html/topics/impala_fetch_rows_timeout_ms.html
A docs/build/html/topics/impala_file_formats.html
A docs/build/html/topics/impala_fixed_issues.html
A docs/build/html/topics/impala_float.html
A docs/build/html/topics/impala_functions.html
A docs/build/html/topics/impala_functions_overview.html
A docs/build/html/topics/impala_grant.html
A docs/build/html/topics/impala_group_by.html
A docs/build/html/topics/impala_group_concat.html
A docs/build/html/topics/impala_hadoop.html
A docs/build/html/topics/impala_having.html
A docs/build/html/topics/impala_hbase.html
A docs/build/html/topics/impala_hbase_cache_blocks.html
A docs/build/html/topics/impala_hbase_caching.html
A docs/build/html/topics/impala_hints.html
A docs/build/html/topics/impala_hudi.html
A docs/build/html/topics/impala_iceberg.html
A docs/build/html/topics/impala_identifiers.html
A docs/build/html/topics/impala_idle_session_timeout.html
A docs/build/html/topics/impala_impala_shell.html
A docs/build/html/topics/impala_incompatible_changes.html
A docs/build/html/topics/impala_insert.html
A docs/build/html/topics/impala_install.html
A docs/build/html/topics/impala_int.html
A docs/build/html/topics/impala_intro.html
A docs/build/html/topics/impala_invalidate_metadata.html
A docs/build/html/topics/impala_isilon.html
A docs/build/html/topics/impala_jdbc.html
A docs/build/html/topics/impala_join_rows_produced_limit.html
A docs/build/html/topics/impala_joins.html
A docs/build/html/topics/impala_kerberos.html
A docs/build/html/topics/impala_known_issues.html
A docs/build/html/topics/impala_kudu.html
A docs/build/html/topics/impala_kudu_read_mode.html
A docs/build/html/topics/impala_langref.html
A docs/build/html/topics/impala_langref_sql.html
A docs/build/html/topics/impala_langref_unsupported.html
A docs/build/html/topics/impala_ldap.html
A docs/build/html/topics/impala_limit.html
A docs/build/html/topics/impala_lineage.html
A docs/build/html/topics/impala_literals.html
A docs/build/html/topics/impala_live_progress.html
A docs/build/html/topics/impala_live_summary.html
A docs/build/html/topics/impala_load_data.html
A docs/build/html/topics/impala_logging.html
A docs/build/html/topics/impala_map.html
A docs/build/html/topics/impala_math_functions.html
A docs/build/html/topics/impala_max.html
A docs/build/html/topics/impala_max_errors.html
A docs/build/html/topics/impala_max_mem_estimate_for_admission.html
A docs/build/html/topics/impala_max_num_runtime_filters.html
A docs/build/html/topics/impala_max_result_spooling_mem.html
A docs/build/html/topics/impala_max_row_size.html
A docs/build/html/topics/impala_max_scan_range_length.html
A docs/build/html/topics/impala_max_spilled_result_spooling_mem.html
A docs/build/html/topics/impala_mem_limit.html
A docs/build/html/topics/impala_metadata.html
A docs/build/html/topics/impala_min.html
A docs/build/html/topics/impala_min_spillable_buffer_size.html
A docs/build/html/topics/impala_misc_functions.html
A docs/build/html/topics/impala_mixed_security.html
A docs/build/html/topics/impala_mt_dop.html
A docs/build/html/topics/impala_ndv.html
A docs/build/html/topics/impala_new_features.html
A docs/build/html/topics/impala_node_blacklisting.html
A docs/build/html/topics/impala_num_nodes.html
A docs/build/html/topics/impala_num_rows_produced_limit.html
A docs/build/html/topics/impala_num_scanner_threads.html
A docs/build/html/topics/impala_odbc.html
A docs/build/html/topics/impala_offset.html
A docs/build/html/topics/impala_operators.html
A docs/build/html/topics/impala_optimize_partition_key_scans.html
A docs/build/html/topics/impala_orc.html
A docs/build/html/topics/impala_order_by.html
A docs/build/html/topics/impala_parquet.html
A docs/build/html/topics/impala_parquet_annotate_strings_utf8.html
A docs/build/html/topics/impala_parquet_array_resolution.html
A docs/build/html/topics/impala_parquet_compression_codec.html
A docs/build/html/topics/impala_parquet_dictionary_filtering.html
A docs/build/html/topics/impala_parquet_fallback_schema_resolution.html
A docs/build/html/topics/impala_parquet_file_size.html
A docs/build/html/topics/impala_parquet_object_store_split_size.html
A docs/build/html/topics/impala_parquet_page_row_count_limit.html
A docs/build/html/topics/impala_parquet_read_page_index.html
A docs/build/html/topics/impala_parquet_read_statistics.html
A docs/build/html/topics/impala_parquet_write_page_index.html
A docs/build/html/topics/impala_partitioning.html
A docs/build/html/topics/impala_perf_benchmarking.html
A docs/build/html/topics/impala_perf_cookbook.html
A docs/build/html/topics/impala_perf_hdfs_caching.html
A docs/build/html/topics/impala_perf_joins.html
A docs/build/html/topics/impala_perf_resources.html
A docs/build/html/topics/impala_perf_skew.html
A docs/build/html/topics/impala_perf_stats.html
A docs/build/html/topics/impala_perf_testing.html
A docs/build/html/topics/impala_performance.html
A docs/build/html/topics/impala_planning.html
A docs/build/html/topics/impala_porting.html
A docs/build/html/topics/impala_ports.html
A docs/build/html/topics/impala_prefetch_mode.html
A docs/build/html/topics/impala_prereqs.html
A docs/build/html/topics/impala_processes.html
A docs/build/html/topics/impala_proxy.html
A docs/build/html/topics/impala_query_options.html
A docs/build/html/topics/impala_query_results_spooling.html
A docs/build/html/topics/impala_query_timeout_s.html
A docs/build/html/topics/impala_rcfile.html
A docs/build/html/topics/impala_real.html
A docs/build/html/topics/impala_refresh.html
A docs/build/html/topics/impala_refresh_authorization.html
A docs/build/html/topics/impala_refresh_functions.html
A docs/build/html/topics/impala_refresh_updated_hms.html
A docs/build/html/topics/impala_release_notes.html
A docs/build/html/topics/impala_relnotes.html
A docs/build/html/topics/impala_replica_preference.html
A docs/build/html/topics/impala_request_pool.html
A docs/build/html/topics/impala_reserved_words.html
A docs/build/html/topics/impala_resource_management.html
A docs/build/html/topics/impala_resource_trace_ratio.html
A docs/build/html/topics/impala_retry_failed_queries.html
A docs/build/html/topics/impala_revoke.html
A docs/build/html/topics/impala_runtime_bloom_filter_size.html
A docs/build/html/topics/impala_runtime_filter_max_size.html
A docs/build/html/topics/impala_runtime_filter_min_size.html
A docs/build/html/topics/impala_runtime_filter_mode.html
A docs/build/html/topics/impala_runtime_filter_wait_time_ms.html
A docs/build/html/topics/impala_runtime_filtering.html
A docs/build/html/topics/impala_s3.html
A docs/build/html/topics/impala_s3_skip_insert_staging.html
A docs/build/html/topics/impala_scalability.html
A docs/build/html/topics/impala_scaling_limits.html
A docs/build/html/topics/impala_scan_bytes_limit.html
A docs/build/html/topics/impala_schedule_random_replica.html
A docs/build/html/topics/impala_schema_design.html
A docs/build/html/topics/impala_schema_objects.html
A docs/build/html/topics/impala_scratch_limit.html
A docs/build/html/topics/impala_security.html
A docs/build/html/topics/impala_security_files.html
A docs/build/html/topics/impala_security_guidelines.html
A docs/build/html/topics/impala_security_install.html
A docs/build/html/topics/impala_security_metastore.html
A docs/build/html/topics/impala_security_webui.html
A docs/build/html/topics/impala_select.html
A docs/build/html/topics/impala_seqfile.html
A docs/build/html/topics/impala_set.html
A docs/build/html/topics/impala_shell_commands.html
A docs/build/html/topics/impala_shell_options.html
A docs/build/html/topics/impala_shell_running_commands.html
A docs/build/html/topics/impala_show.html
A docs/build/html/topics/impala_shuffle_distinct_exprs.html
A docs/build/html/topics/impala_shutdown.html
A docs/build/html/topics/impala_smallint.html
A docs/build/html/topics/impala_spool_query_results.html
A docs/build/html/topics/impala_ssl.html
A docs/build/html/topics/impala_stddev.html
A docs/build/html/topics/impala_string.html
A docs/build/html/topics/impala_string_functions.html
A docs/build/html/topics/impala_struct.html
A docs/build/html/topics/impala_subqueries.html
A docs/build/html/topics/impala_sum.html
A docs/build/html/topics/impala_support_start_over.html
A docs/build/html/topics/impala_sync_ddl.html
A docs/build/html/topics/impala_tables.html
A docs/build/html/topics/impala_tablesample.html
A docs/build/html/topics/impala_thread_reservation_aggregate_limit.html
A docs/build/html/topics/impala_thread_reservation_limit.html
A docs/build/html/topics/impala_timeouts.html
A docs/build/html/topics/impala_timestamp.html
A docs/build/html/topics/impala_timezone.html
A docs/build/html/topics/impala_tinyint.html
A docs/build/html/topics/impala_topn_bytes_limit.html
A docs/build/html/topics/impala_transactions.html
A docs/build/html/topics/impala_transparent_query_retries.html
A docs/build/html/topics/impala_troubleshooting.html
A docs/build/html/topics/impala_truncate_table.html
A docs/build/html/topics/impala_tutorial.html
A docs/build/html/topics/impala_txtfile.html
A docs/build/html/topics/impala_udf.html
A docs/build/html/topics/impala_union.html
A docs/build/html/topics/impala_update.html
A docs/build/html/topics/impala_upgrading.html
A docs/build/html/topics/impala_upsert.html
A docs/build/html/topics/impala_use.html
A docs/build/html/topics/impala_utf8_mode.html
A docs/build/html/topics/impala_utf_8.html
A docs/build/html/topics/impala_values.html
A docs/build/html/topics/impala_varchar.html
A docs/build/html/topics/impala_variance.html
A docs/build/html/topics/impala_views.html
A docs/build/html/topics/impala_webui.html
A docs/build/html/topics/impala_with.html
294 files changed, 108,094 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/19402/1
--
To view, visit http://gerrit.cloudera.org:8080/19402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab1d5fe5e3be85f26aeeb24be9e0018935d2e424
Gerrit-Change-Number: 19402
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
[Impala-ASF-CR](asf-site) IMPALA-11825: Doc update 4.2.0 breaks web search results
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19402 )
Change subject: IMPALA-11825: Doc update 4.2.0 breaks web search results
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab1d5fe5e3be85f26aeeb24be9e0018935d2e424
Gerrit-Change-Number: 19402
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Jan 2023 13:58:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) IMPALA-11825: Doc update 4.2.0 breaks web search results
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has uploaded a new patch set (#3) to the change originally created by Daniel Becker. ( http://gerrit.cloudera.org:8080/19402 )
Change subject: IMPALA-11825: Doc update 4.2.0 breaks web search results
......................................................................
IMPALA-11825: Doc update 4.2.0 breaks web search results
We recently updated the upstream Impala docs in
https://gerrit.cloudera.org/#/c/19367/. The doc build system introduced
a new directory with CSS formatted html but also renamed the old 'html'
directory to 'plain-html'. The problem is that changing the directory
name from 'html' to 'plain-html' breaks web search results as they still
have the old links.
This change adds a symlink from 'html' to 'asf-site-html' to fix it.
Change-Id: Iab1d5fe5e3be85f26aeeb24be9e0018935d2e424
---
A docs/build/html
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/19402/3
--
To view, visit http://gerrit.cloudera.org:8080/19402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iab1d5fe5e3be85f26aeeb24be9e0018935d2e424
Gerrit-Change-Number: 19402
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR](asf-site) IMPALA-11825: Doc update 4.2.0 breaks web search results
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19402 )
Change subject: IMPALA-11825: Doc update 4.2.0 breaks web search results
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/687/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/19402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab1d5fe5e3be85f26aeeb24be9e0018935d2e424
Gerrit-Change-Number: 19402
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Jan 2023 15:02:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) IMPALA-11825: Doc update 4.2.0 breaks web search results
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19402 )
Change subject: IMPALA-11825: Doc update 4.2.0 breaks web search results
......................................................................
Patch Set 1: Verified-1
Build Failed
https://jenkins.impala.io/job/gerrit-docs-auto-test/687/ : Doc tests failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/19402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab1d5fe5e3be85f26aeeb24be9e0018935d2e424
Gerrit-Change-Number: 19402
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Comment-Date: Thu, 05 Jan 2023 15:07:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) IMPALA-11825: Doc update 4.2.0 breaks web search results
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19402 )
Change subject: IMPALA-11825: Doc update 4.2.0 breaks web search results
......................................................................
IMPALA-11825: Doc update 4.2.0 breaks web search results
We recently updated the upstream Impala docs in
https://gerrit.cloudera.org/#/c/19367/. The doc build system introduced
a new directory with CSS formatted html but also renamed the old 'html'
directory to 'plain-html'. The problem is that changing the directory
name from 'html' to 'plain-html' breaks web search results as they still
have the old links.
This change adds a symlink from 'html' to 'asf-site-html' to fix it.
Change-Id: Iab1d5fe5e3be85f26aeeb24be9e0018935d2e424
Reviewed-on: http://gerrit.cloudera.org:8080/19402
Reviewed-by: Quanlong Huang <hu...@gmail.com>
Tested-by: Quanlong Huang <hu...@gmail.com>
---
A docs/build/html
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Quanlong Huang: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/19402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab1d5fe5e3be85f26aeeb24be9e0018935d2e424
Gerrit-Change-Number: 19402
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR](asf-site) IMPALA-11825: Doc update 4.2.0 breaks web search results
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19402 )
Change subject: IMPALA-11825: Doc update 4.2.0 breaks web search results
......................................................................
Patch Set 2: Verified-1
Build Failed
https://jenkins.impala.io/job/gerrit-docs-auto-test/688/ : Doc tests failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/19402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab1d5fe5e3be85f26aeeb24be9e0018935d2e424
Gerrit-Change-Number: 19402
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Jan 2023 12:49:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) IMPALA-11825: Doc update 4.2.0 breaks web search results
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19402 )
Change subject: IMPALA-11825: Doc update 4.2.0 breaks web search results
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19402/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/19402/2//COMMIT_MSG@16
PS2, Line 16: This change adds a symlink from 'html' to 'asf-site-html' to fix it.
:
> nit: mention symlink instead
Done
--
To view, visit http://gerrit.cloudera.org:8080/19402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab1d5fe5e3be85f26aeeb24be9e0018935d2e424
Gerrit-Change-Number: 19402
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Jan 2023 13:58:12 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR](asf-site) IMPALA-11825: Doc update 4.2.0 breaks web search results
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19402 )
Change subject: IMPALA-11825: Doc update 4.2.0 breaks web search results
......................................................................
Patch Set 1:
Instead of deep copying the whole folder, can we just create a symlink of "html -> asf-site-html" ? It works in my local env:
git fetch http://gerrit.cloudera.org:8080/Impala-ASF refs/changes/02/19402/1 && git checkout FETCH_HEAD
cd docs/build
rm -rf html
ln -s asf-site-html html
Open html/index.html in the browser. It seems other links also work.
--
To view, visit http://gerrit.cloudera.org:8080/19402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab1d5fe5e3be85f26aeeb24be9e0018935d2e424
Gerrit-Change-Number: 19402
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Jan 2023 00:52:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) IMPALA-11825: Doc update 4.2.0 breaks web search results
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19402 )
Change subject: IMPALA-11825: Doc update 4.2.0 breaks web search results
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/688/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/19402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab1d5fe5e3be85f26aeeb24be9e0018935d2e424
Gerrit-Change-Number: 19402
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 06 Jan 2023 12:45:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) IMPALA-11825: Doc update 4.2.0 breaks web search results
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/19402 )
Change subject: IMPALA-11825: Doc update 4.2.0 breaks web search results
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab1d5fe5e3be85f26aeeb24be9e0018935d2e424
Gerrit-Change-Number: 19402
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Jan 2023 15:30:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](asf-site) IMPALA-11825: Doc update 4.2.0 breaks web search results
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/19402 )
Change subject: IMPALA-11825: Doc update 4.2.0 breaks web search results
......................................................................
IMPALA-11825: Doc update 4.2.0 breaks web search results
We recently updated the upstream Impala docs in
https://gerrit.cloudera.org/#/c/19367/. The doc build system introduced
a new directory with CSS formatted html but also renamed the old 'html'
directory to 'plain-html'. The problem is that changing the directory
name from 'html' to 'plain-html' breaks web search results as they still
have the old links.
This change is a quick and dirty fix. It duplicates the 'asf-site-html'
directory as 'html' so the old web links continue to work. We should
come up with a clean solution in a follow-up change.
Change-Id: Iab1d5fe5e3be85f26aeeb24be9e0018935d2e424
---
A docs/build/html
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/19402/2
--
To view, visit http://gerrit.cloudera.org:8080/19402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: asf-site
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iab1d5fe5e3be85f26aeeb24be9e0018935d2e424
Gerrit-Change-Number: 19402
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>