[jira] [Resolved] (OAK-4434) Remove segment version argument from segment writer and and related classes

["Michael Dürig (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OAK-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Dürig resolved OAK-4434.
--------------------------------
    Resolution: Fixed

Fixed at http://svn.apache.org/viewvc?rev=1747166&view=rev

> Remove segment version argument from segment writer and and related classes
> ---------------------------------------------------------------------------
>
>                 Key: OAK-4434
>                 URL: https://issues.apache.org/jira/browse/OAK-4434
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segment-tar
>            Reporter: Michael Dürig
>            Assignee: Michael Dürig
>              Labels: refactoring
>             Fix For: 1.6
>
>
> The {{SegmentWriter}} and its related classes accept a {{SegmentVersion}} argument. This is confusing since that version is only stored in the segment's segment version field. The writer cannot and does not actually write segments at older version than the latest (12). 
> I suggest we remove the explicit segment version from all classes where it can be specified and hard code the segment version to 12 for now. This is the only segment version {{segment-tar}} currently supports anyway. Should  the need to support other segment version arise in the future, we need to decide at that point how to parametrise {{segment-tar}} on the segment version. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)