You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2026/05/28 15:50:15 UTC

[Impala-ASF-CR] WIP: update TCLIService.thrift

Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24376


Change subject: WIP: update TCLIService.thrift
......................................................................

WIP: update TCLIService.thrift

Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
---
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-server.h
M common/thrift/hive-1-api/TCLIService.thrift
3 files changed, 180 insertions(+), 9 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/24376/1
-- 
To view, visit http://gerrit.cloudera.org:8080/24376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
Gerrit-Change-Number: 24376
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>

[Impala-ASF-CR] IMPALA-12696: Update HS2 definitions (TCLIService.thrift)

Posted by "Balazs Hevele (Code Review)" <ge...@cloudera.org>.
Balazs Hevele has posted comments on this change. ( http://gerrit.cloudera.org:8080/24376 )

Change subject: IMPALA-12696: Update HS2 definitions (TCLIService.thrift)
......................................................................


Patch Set 6: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
Gerrit-Change-Number: 24376
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Jun 2026 19:13:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12696: Update HS2 definitions (TCLIService.thrift)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24376 )

Change subject: IMPALA-12696: Update HS2 definitions (TCLIService.thrift)
......................................................................


Patch Set 7: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
Gerrit-Change-Number: 24376
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Jun 2026 20:34:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12696: Update HS2 definitions (TCLIService.thrift)

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/24376 )

Change subject: IMPALA-12696: Update HS2 definitions (TCLIService.thrift)
......................................................................


Patch Set 6: Code-Review+1

This is looking good to me. In a future change, we can implement support for the newer protocol versions. I think I'm ok to go to +2 if there are not other comments.


-- 
To view, visit http://gerrit.cloudera.org:8080/24376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
Gerrit-Change-Number: 24376
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Jun 2026 18:39:13 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12696: Update HS2 definitions (TCLIService.thrift)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24376 )

Change subject: IMPALA-12696: Update HS2 definitions (TCLIService.thrift)
......................................................................


Patch Set 3:

(4 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24376/3/common/thrift/hive-1-api/TCLIService.thrift
File common/thrift/hive-1-api/TCLIService.thrift:

http://gerrit.cloudera.org:8080/#/c/24376/3/common/thrift/hive-1-api/TCLIService.thrift@348
PS3, Line 348:   7: TStringValue stringVal    // STRING, LIST, MAP, STRUCT, UNIONTYPE, BINARY, DECIMAL, NULL, INTERVAL_YEAR_MONTH, INTERVAL_DAY_TIME
line too long (133 > 90)


http://gerrit.cloudera.org:8080/#/c/24376/3/common/thrift/hive-1-api/TCLIService.thrift@573
PS3, Line 573:   1: required TProtocolVersion client_protocol = TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V10
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/24376/3/common/thrift/hive-1-api/TCLIService.thrift@592
PS3, Line 592:   2: required TProtocolVersion serverProtocolVersion = TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V10
line too long (101 > 90)


http://gerrit.cloudera.org:8080/#/c/24376/3/common/thrift/hive-1-api/TCLIService.thrift@826
PS3, Line 826: // Retrieves the schema names available in this database. 
line has trailing whitespace



-- 
To view, visit http://gerrit.cloudera.org:8080/24376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
Gerrit-Change-Number: 24376
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 May 2026 19:28:25 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] WIP: update TCLIService.thrift

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24376 )

Change subject: WIP: update TCLIService.thrift
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/22647/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
Gerrit-Change-Number: 24376
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 May 2026 09:07:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12696: Update HS2 definitions (TCLIService.thrift)

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24376

to look at the new patch set (#3).

Change subject: IMPALA-12696: Update HS2 definitions (TCLIService.thrift)
......................................................................

IMPALA-12696: Update HS2 definitions (TCLIService.thrift)

Update to "fresh" (didn't change since since 2022) TClIService.thrift
from Hive repo.
Mainly a copy of Hive version, but some changes were needed:
- change python namespace to impala_thrift_gen.TCLIService
- reorder a few structs to avoid compilation errors in c++
- readd GetLog()

Implements one of the new functions (GetQueryId) and returns
"not implemented" error for others.

Realized last minute that there is a very similar prototype
review:
https://gerrit.cloudera.org/#/c/20495/
My change does almost the same, but updates to a bit newer version
and does not change server behavior, e.g. doesn't bump
MAX_SUPPORTED_HS2_VERSION. Using the new possibilites in the
protocol could be done in follow up commits.

Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
---
M be/src/rpc/hs2-http-test.cc
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-server.h
M common/thrift/hive-1-api/TCLIService.thrift
M tests/hs2/test_hs2.py
5 files changed, 261 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/24376/3
-- 
To view, visit http://gerrit.cloudera.org:8080/24376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
Gerrit-Change-Number: 24376
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-12696: Update HS2 definitions (TCLIService.thrift)

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24376 )

Change subject: IMPALA-12696: Update HS2 definitions (TCLIService.thrift)
......................................................................

IMPALA-12696: Update HS2 definitions (TCLIService.thrift)

Update to "fresh" (didn't change since 2022) TCLIService.thrift
from Hive repo.
Mainly a copy of Hive version, but some changes were needed:
- change python namespace to impala_thrift_gen.TCLIService
- reorder a few structs to avoid compilation errors in c++
- readd GetLog()

Implements one of the new functions (GetQueryId) and returns
"not implemented" error for others.

Realized last minute that there is a very similar prototype
review:
https://gerrit.cloudera.org/#/c/20495/
My change does almost the same, but updates to a bit newer version
and does not change server behavior, e.g. doesn't bump
MAX_SUPPORTED_HS2_VERSION. The main motivation is providing the
generated python artifacts for impyla which is also used with Hive.
Using the new possibilites in the protocol could be done in follow up
patches.

Generated-by: Cloude Sonnet 4.6

Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
Reviewed-on: http://gerrit.cloudera.org:8080/24376
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
Tested-by: Csaba Ringhofer <cs...@cloudera.com>
---
M be/src/rpc/hs2-http-test.cc
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-server.h
M common/thrift/hive-1-api/TCLIService.thrift
M tests/hs2/test_hs2.py
5 files changed, 261 insertions(+), 15 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved
  Csaba Ringhofer: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/24376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
Gerrit-Change-Number: 24376
Gerrit-PatchSet: 8
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-12696: Update HS2 definitions (TCLIService.thrift)

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has removed a vote on this change.

Change subject: IMPALA-12696: Update HS2 definitions (TCLIService.thrift)
......................................................................


Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
-- 
To view, visit http://gerrit.cloudera.org:8080/24376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
Gerrit-Change-Number: 24376
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-12696: Update HS2 definitions (TCLIService.thrift)

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24376 )

Change subject: IMPALA-12696: Update HS2 definitions (TCLIService.thrift)
......................................................................


Patch Set 6: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/24376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
Gerrit-Change-Number: 24376
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Jun 2026 20:34:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12696: Update HS2 definitions (TCLIService.thrift)

Posted by "Balazs Hevele (Code Review)" <ge...@cloudera.org>.
Balazs Hevele has posted comments on this change. ( http://gerrit.cloudera.org:8080/24376 )

Change subject: IMPALA-12696: Update HS2 definitions (TCLIService.thrift)
......................................................................


Patch Set 5:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/24376/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/24376/5//COMMIT_MSG@9
PS5, Line 9: l
nit: capital L


http://gerrit.cloudera.org:8080/#/c/24376/5//COMMIT_MSG@9
PS5, Line 9: since since
nit: since


http://gerrit.cloudera.org:8080/#/c/24376/5/be/src/service/impala-hs2-server.cc
File be/src/service/impala-hs2-server.cc:

http://gerrit.cloudera.org:8080/#/c/24376/5/be/src/service/impala-hs2-server.cc@1361
PS5, Line 1361: setNotImplementedError
nit: why not SetNotImplementedError (with capital S)?


http://gerrit.cloudera.org:8080/#/c/24376/5/be/src/service/impala-hs2-server.cc@1361
PS5, Line 1361: void
Could be a static function.



-- 
To view, visit http://gerrit.cloudera.org:8080/24376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
Gerrit-Change-Number: 24376
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Jun 2026 09:25:49 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12696: Update HS2 definitions (TCLIService.thrift)

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24376

to look at the new patch set (#5).

Change subject: IMPALA-12696: Update HS2 definitions (TCLIService.thrift)
......................................................................

IMPALA-12696: Update HS2 definitions (TCLIService.thrift)

Update to "fresh" (didn't change since since 2022) TClIService.thrift
from Hive repo.
Mainly a copy of Hive version, but some changes were needed:
- change python namespace to impala_thrift_gen.TCLIService
- reorder a few structs to avoid compilation errors in c++
- readd GetLog()

Implements one of the new functions (GetQueryId) and returns
"not implemented" error for others.

Realized last minute that there is a very similar prototype
review:
https://gerrit.cloudera.org/#/c/20495/
My change does almost the same, but updates to a bit newer version
and does not change server behavior, e.g. doesn't bump
MAX_SUPPORTED_HS2_VERSION. The main motivation is providing the
generated python artifacts for impyla which is also used with Hive.
Using the new possibilites in the protocol could be done in follow up
patches.

Generated-by: Cloude Sonnet 4.6

Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
---
M be/src/rpc/hs2-http-test.cc
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-server.h
M common/thrift/hive-1-api/TCLIService.thrift
M tests/hs2/test_hs2.py
5 files changed, 261 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/24376/5
-- 
To view, visit http://gerrit.cloudera.org:8080/24376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
Gerrit-Change-Number: 24376
Gerrit-PatchSet: 5
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-12696: Update HS2 definitions (TCLIService.thrift)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24376 )

Change subject: IMPALA-12696: Update HS2 definitions (TCLIService.thrift)
......................................................................


Patch Set 7: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/13594/


-- 
To view, visit http://gerrit.cloudera.org:8080/24376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
Gerrit-Change-Number: 24376
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Jun 2026 01:04:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12696: Update HS2 definitions (TCLIService.thrift)

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24376 )

Change subject: IMPALA-12696: Update HS2 definitions (TCLIService.thrift)
......................................................................


Patch Set 6:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/24376/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/24376/5//COMMIT_MSG@9
PS5, Line 9: since 2022)
> nit: since
Done


http://gerrit.cloudera.org:8080/#/c/24376/5//COMMIT_MSG@9
PS5, Line 9: i
> nit: capital L
Done


http://gerrit.cloudera.org:8080/#/c/24376/5/be/src/service/impala-hs2-server.cc
File be/src/service/impala-hs2-server.cc:

http://gerrit.cloudera.org:8080/#/c/24376/5/be/src/service/impala-hs2-server.cc@1361
PS5, Line 1361: c void SetNotImplement
> nit: why not SetNotImplementedError (with capital S)?
Done


http://gerrit.cloudera.org:8080/#/c/24376/5/be/src/service/impala-hs2-server.cc@1361
PS5, Line 1361: stat
> Could be a static function.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/24376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
Gerrit-Change-Number: 24376
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Jun 2026 14:59:47 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12696: Update HS2 definitions (TCLIService.thrift)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24376 )

Change subject: IMPALA-12696: Update HS2 definitions (TCLIService.thrift)
......................................................................


Patch Set 6:

(4 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24376/6/common/thrift/hive-1-api/TCLIService.thrift
File common/thrift/hive-1-api/TCLIService.thrift:

http://gerrit.cloudera.org:8080/#/c/24376/6/common/thrift/hive-1-api/TCLIService.thrift@348
PS6, Line 348:   7: TStringValue stringVal    // STRING, LIST, MAP, STRUCT, UNIONTYPE, BINARY, DECIMAL, NULL, INTERVAL_YEAR_MONTH, INTERVAL_DAY_TIME
line too long (133 > 90)


http://gerrit.cloudera.org:8080/#/c/24376/6/common/thrift/hive-1-api/TCLIService.thrift@573
PS6, Line 573:   1: required TProtocolVersion client_protocol = TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V10
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/24376/6/common/thrift/hive-1-api/TCLIService.thrift@592
PS6, Line 592:   2: required TProtocolVersion serverProtocolVersion = TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V10
line too long (101 > 90)


http://gerrit.cloudera.org:8080/#/c/24376/6/common/thrift/hive-1-api/TCLIService.thrift@826
PS6, Line 826: // Retrieves the schema names available in this database. 
line has trailing whitespace



-- 
To view, visit http://gerrit.cloudera.org:8080/24376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
Gerrit-Change-Number: 24376
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Jun 2026 15:01:14 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] WIP: update TCLIService.thrift

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24376 )

Change subject: WIP: update TCLIService.thrift
......................................................................


Patch Set 2:

(4 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24376/2/common/thrift/hive-1-api/TCLIService.thrift
File common/thrift/hive-1-api/TCLIService.thrift:

http://gerrit.cloudera.org:8080/#/c/24376/2/common/thrift/hive-1-api/TCLIService.thrift@348
PS2, Line 348:   7: TStringValue stringVal    // STRING, LIST, MAP, STRUCT, UNIONTYPE, BINARY, DECIMAL, NULL, INTERVAL_YEAR_MONTH, INTERVAL_DAY_TIME
line too long (133 > 90)


http://gerrit.cloudera.org:8080/#/c/24376/2/common/thrift/hive-1-api/TCLIService.thrift@573
PS2, Line 573:   1: required TProtocolVersion client_protocol = TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V10
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/24376/2/common/thrift/hive-1-api/TCLIService.thrift@592
PS2, Line 592:   2: required TProtocolVersion serverProtocolVersion = TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V10
line too long (101 > 90)


http://gerrit.cloudera.org:8080/#/c/24376/2/common/thrift/hive-1-api/TCLIService.thrift@826
PS2, Line 826: // Retrieves the schema names available in this database. 
line has trailing whitespace



-- 
To view, visit http://gerrit.cloudera.org:8080/24376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
Gerrit-Change-Number: 24376
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 May 2026 08:48:33 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] WIP: update TCLIService.thrift

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24376

to look at the new patch set (#2).

Change subject: WIP: update TCLIService.thrift
......................................................................

WIP: update TCLIService.thrift

Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
---
M be/src/rpc/hs2-http-test.cc
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-server.h
M common/thrift/hive-1-api/TCLIService.thrift
4 files changed, 184 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/24376/2
-- 
To view, visit http://gerrit.cloudera.org:8080/24376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
Gerrit-Change-Number: 24376
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-12696: Update HS2 definitions (TCLIService.thrift)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24376 )

Change subject: IMPALA-12696: Update HS2 definitions (TCLIService.thrift)
......................................................................


Patch Set 7:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13594/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/24376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
Gerrit-Change-Number: 24376
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 08 Jun 2026 20:34:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: update TCLIService.thrift

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24376 )

Change subject: WIP: update TCLIService.thrift
......................................................................


Patch Set 1:

(4 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24376/1/common/thrift/hive-1-api/TCLIService.thrift
File common/thrift/hive-1-api/TCLIService.thrift:

http://gerrit.cloudera.org:8080/#/c/24376/1/common/thrift/hive-1-api/TCLIService.thrift@348
PS1, Line 348:   7: TStringValue stringVal    // STRING, LIST, MAP, STRUCT, UNIONTYPE, BINARY, DECIMAL, NULL, INTERVAL_YEAR_MONTH, INTERVAL_DAY_TIME
line too long (133 > 90)


http://gerrit.cloudera.org:8080/#/c/24376/1/common/thrift/hive-1-api/TCLIService.thrift@573
PS1, Line 573:   1: required TProtocolVersion client_protocol = TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V10
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/24376/1/common/thrift/hive-1-api/TCLIService.thrift@592
PS1, Line 592:   2: required TProtocolVersion serverProtocolVersion = TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V10
line too long (101 > 90)


http://gerrit.cloudera.org:8080/#/c/24376/1/common/thrift/hive-1-api/TCLIService.thrift@826
PS1, Line 826: // Retrieves the schema names available in this database. 
line has trailing whitespace



-- 
To view, visit http://gerrit.cloudera.org:8080/24376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
Gerrit-Change-Number: 24376
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 May 2026 15:52:32 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] WIP: update TCLIService.thrift

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24376 )

Change subject: WIP: update TCLIService.thrift
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13547/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/24376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
Gerrit-Change-Number: 24376
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 May 2026 15:51:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12696: Update HS2 definitions (TCLIService.thrift)

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24376

to look at the new patch set (#4).

Change subject: IMPALA-12696: Update HS2 definitions (TCLIService.thrift)
......................................................................

IMPALA-12696: Update HS2 definitions (TCLIService.thrift)

Update to "fresh" (didn't change since since 2022) TClIService.thrift
from Hive repo.
Mainly a copy of Hive version, but some changes were needed:
- change python namespace to impala_thrift_gen.TCLIService
- reorder a few structs to avoid compilation errors in c++
- readd GetLog()

Implements one of the new functions (GetQueryId) and returns
"not implemented" error for others.

Realized last minute that there is a very similar prototype
review:
https://gerrit.cloudera.org/#/c/20495/
My change does almost the same, but updates to a bit newer version
and does not change server behavior, e.g. doesn't bump
MAX_SUPPORTED_HS2_VERSION. The main motivation is providing the
generated python artifacts for impyla which is also used with Hive.
Using the new possibilites in the protocol could be done in follow up
patches.

Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
---
M be/src/rpc/hs2-http-test.cc
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-server.h
M common/thrift/hive-1-api/TCLIService.thrift
M tests/hs2/test_hs2.py
5 files changed, 261 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/24376/4
-- 
To view, visit http://gerrit.cloudera.org:8080/24376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
Gerrit-Change-Number: 24376
Gerrit-PatchSet: 4
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-12696: Update HS2 definitions (TCLIService.thrift)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24376 )

Change subject: IMPALA-12696: Update HS2 definitions (TCLIService.thrift)
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/22662/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
Gerrit-Change-Number: 24376
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 May 2026 19:51:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12696: Update HS2 definitions (TCLIService.thrift)

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Hello Balazs Hevele, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/24376

to look at the new patch set (#6).

Change subject: IMPALA-12696: Update HS2 definitions (TCLIService.thrift)
......................................................................

IMPALA-12696: Update HS2 definitions (TCLIService.thrift)

Update to "fresh" (didn't change since 2022) TCLIService.thrift
from Hive repo.
Mainly a copy of Hive version, but some changes were needed:
- change python namespace to impala_thrift_gen.TCLIService
- reorder a few structs to avoid compilation errors in c++
- readd GetLog()

Implements one of the new functions (GetQueryId) and returns
"not implemented" error for others.

Realized last minute that there is a very similar prototype
review:
https://gerrit.cloudera.org/#/c/20495/
My change does almost the same, but updates to a bit newer version
and does not change server behavior, e.g. doesn't bump
MAX_SUPPORTED_HS2_VERSION. The main motivation is providing the
generated python artifacts for impyla which is also used with Hive.
Using the new possibilites in the protocol could be done in follow up
patches.

Generated-by: Cloude Sonnet 4.6

Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
---
M be/src/rpc/hs2-http-test.cc
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-server.h
M common/thrift/hive-1-api/TCLIService.thrift
M tests/hs2/test_hs2.py
5 files changed, 261 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/24376/6
-- 
To view, visit http://gerrit.cloudera.org:8080/24376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
Gerrit-Change-Number: 24376
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-12696: Update HS2 definitions (TCLIService.thrift)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24376 )

Change subject: IMPALA-12696: Update HS2 definitions (TCLIService.thrift)
......................................................................


Patch Set 6:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/22677/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/24376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
Gerrit-Change-Number: 24376
Gerrit-PatchSet: 6
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 01 Jun 2026 15:22:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: update TCLIService.thrift

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24376 )

Change subject: WIP: update TCLIService.thrift
......................................................................


Patch Set 1: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/13547/


-- 
To view, visit http://gerrit.cloudera.org:8080/24376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
Gerrit-Change-Number: 24376
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 May 2026 18:14:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: update TCLIService.thrift

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24376 )

Change subject: WIP: update TCLIService.thrift
......................................................................


Patch Set 1:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/22630/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/24376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
Gerrit-Change-Number: 24376
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 May 2026 16:02:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12696: Update HS2 definitions (TCLIService.thrift)

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24376 )

Change subject: IMPALA-12696: Update HS2 definitions (TCLIService.thrift)
......................................................................


Patch Set 7: Verified+1 Code-Review+2

The test error was in an unrelated flaky test: test_excessive_cerr_ignore_pid

Merging the change.


-- 
To view, visit http://gerrit.cloudera.org:8080/24376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
Gerrit-Change-Number: 24376
Gerrit-PatchSet: 7
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Balazs Hevele <bh...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Jun 2026 05:34:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: update TCLIService.thrift

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24376 )

Change subject: WIP: update TCLIService.thrift
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/13552/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/24376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
Gerrit-Change-Number: 24376
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 May 2026 08:46:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] WIP: update TCLIService.thrift

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24376 )

Change subject: WIP: update TCLIService.thrift
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/24376
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I52027d65c726a7f3abd4557a45c5ddd832fbb6bc
Gerrit-Change-Number: 24376
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 29 May 2026 13:24:28 +0000
Gerrit-HasComments: No