You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/05/25 09:18:27 UTC

[GitHub] [incubator-kvrocks] git-hulk commented on a diff in pull request #606: Fix the slave may crash when restoring the db

git-hulk commented on code in PR #606:
URL: https://github.com/apache/incubator-kvrocks/pull/606#discussion_r881423809


##########
src/server.cc:
##########
@@ -558,8 +558,15 @@ void Server::cron() {
     if (storage_->IsClosing()) continue;

Review Comment:
   Yes, there still have the window between `closing` and the db pointer is ready, since we set it to `true` at the begin of the open db.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org