You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/04/28 23:05:06 UTC
[GitHub] [geode] alb3rtobr opened a new pull request #6394: GEODE-9211: Replace 'GemFire' by 'Geode' in LocatorLauncher & ServerL…
alb3rtobr opened a new pull request #6394:
URL: https://github.com/apache/geode/pull/6394
…auncher
`LocatorLauncher` and `ServerLauncher` classes have a lot of references to `GemFire` in Javadocs. They should be substituted by `Geode`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] alb3rtobr commented on pull request #6394: GEODE-9211: Replace 'GemFire' by 'Geode' in LocatorLauncher & ServerL…
Posted by GitBox <gi...@apache.org>.
alb3rtobr commented on pull request #6394:
URL: https://github.com/apache/geode/pull/6394#issuecomment-849115397
thanks @echobravopapa !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jdeppe-pivotal commented on pull request #6394: GEODE-9211: Replace 'GemFire' by 'Geode' in LocatorLauncher & ServerL…
Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal commented on pull request #6394:
URL: https://github.com/apache/geode/pull/6394#issuecomment-831501023
Besides javadoc changes, there are quite a few external help message related changes. I've request @davebarnes97 to take a quick look too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] alb3rtobr commented on pull request #6394: GEODE-9211: Replace 'GemFire' by 'Geode' in LocatorLauncher & ServerL…
Posted by GitBox <gi...@apache.org>.
alb3rtobr commented on pull request #6394:
URL: https://github.com/apache/geode/pull/6394#issuecomment-848710236
Review by code owners still pending
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] alb3rtobr edited a comment on pull request #6394: GEODE-9211: Replace 'GemFire' by 'Geode' in LocatorLauncher & ServerL…
Posted by GitBox <gi...@apache.org>.
alb3rtobr edited a comment on pull request #6394:
URL: https://github.com/apache/geode/pull/6394#issuecomment-848710236
Kind reminder, review by code owners still pending
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] alb3rtobr commented on pull request #6394: GEODE-9211: Replace 'GemFire' by 'Geode' in LocatorLauncher & ServerL…
Posted by GitBox <gi...@apache.org>.
alb3rtobr commented on pull request #6394:
URL: https://github.com/apache/geode/pull/6394#issuecomment-836827536
@Bill , @echobravopapa or @kirklund could you approve this PR? Its a small change but a code owner review is needed. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] alb3rtobr merged pull request #6394: GEODE-9211: Replace 'GemFire' by 'Geode' in LocatorLauncher & ServerL…
Posted by GitBox <gi...@apache.org>.
alb3rtobr merged pull request #6394:
URL: https://github.com/apache/geode/pull/6394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] onichols-pivotal commented on pull request #6394: GEODE-9211: Replace 'GemFire' by 'Geode' in LocatorLauncher & ServerL…
Posted by GitBox <gi...@apache.org>.
onichols-pivotal commented on pull request #6394:
URL: https://github.com/apache/geode/pull/6394#issuecomment-833161249
this looks like a straightforward search-and-replace. The product is called Geode, after all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org