You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/24 07:31:05 UTC

[GitHub] [airflow] michalslowikowski00 commented on a change in pull request #7743: [AIRFLOW-7075] Operators for storing information from GCS into GA

michalslowikowski00 commented on a change in pull request #7743: [AIRFLOW-7075] Operators for storing information from GCS into GA
URL: https://github.com/apache/airflow/pull/7743#discussion_r396947436
 
 

 ##########
 File path: airflow/providers/google/cloud/hooks/gcs.py
 ##########
 @@ -185,6 +185,10 @@ def download(self, bucket_name, object_name, filename=None):
         :param filename: If set, a local file path where the file should be written to.
         :type filename: str
         """
+
+        # TODO: future improvement check file size before downloading,
 
 Review comment:
   wdyt about creating ticket in github ticket with label `gcs todo` or `technical debt` and store there such `todos`. I am afraid it can be missed in the future.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services