[jira] [Commented] (STORM-1612) netty_unity_test uses hardcoded port

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/STORM-1612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185094#comment-15185094 ] 

ASF GitHub Bot commented on STORM-1612:
---------------------------------------

GitHub user ppoulosk opened a pull request:

    https://github.com/apache/storm/pull/1193

    [STORM-1612] Remove hardcoded port, and unreferenced global from netty_unit_test

    Just remove the unnecessary hardcoded port, so that the call will return an ephemeral port, and remove unused global "port".

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ppoulosk/storm STORM-1612

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1193.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1193
    
----
commit 54a501e04254b06baf58e86c4767c925ce7f9d80
Author: Paul Poulosky <pp...@thenperfect-lm.champ.corp.yahoo.com>
Date:   2016-03-08T15:29:15Z

    Remove hardcoded port, and unreferenced global from netty_unit_test

----


> netty_unity_test uses hardcoded port 
> -------------------------------------
>
>                 Key: STORM-1612
>                 URL: https://issues.apache.org/jira/browse/STORM-1612
>             Project: Apache Storm
>          Issue Type: Bug
>            Reporter: Paul Poulosky
>            Assignee: Paul Poulosky
>
> netty_unit_test has a hardcoded port of 6700 in all of its test cases. It would be better to use an ephemeral port on systems running other tests / jobs to avoid the possibility of a port conflict.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)