You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/04/05 05:08:53 UTC
[GitHub] [shardingsphere] Devamparikh opened a new pull request, #16595: Splitting assertMethod() method in different test cases
Devamparikh opened a new pull request, #16595:
URL: https://github.com/apache/shardingsphere/pull/16595
Fixes #16507.
Changes proposed in this pull request:
- Splitting assertMethod( ) in different test cases as discussed in above issue.
- No code breakage.
- Every thing working fine.
Let me know if there is any more changes that I can do to make this code more efficient! ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] taojintianxia commented on a diff in pull request #16595: Splitting assertMethod() method in different test cases
Posted by GitBox <gi...@apache.org>.
taojintianxia commented on code in PR #16595:
URL: https://github.com/apache/shardingsphere/pull/16595#discussion_r842353487
##########
shardingsphere-mode/shardingsphere-mode-type/shardingsphere-standalone-mode/shardingsphere-standalone-mode-repository/shardingsphere-standalone-mode-repository-provider/shardingsphere-standalone-mode-repository-h2/src/test/java/org/apache/shardingsphere/mode/repository/standalone/h2/H2RepositoryTest.java:
##########
@@ -34,38 +34,40 @@
@Test
public void assertMethod() {
assertThat(h2Repository.getType(), is("H2"));
- assertSetProperty();
- assertPersistAndGet();
- assertPersistAndGetChildrenKeys();
- assertDelete();
h2Repository.close();
}
-
- private void assertSetProperty() {
+
+ public void assertSetProperty() {
Review Comment:
there is no `@Test` annotation, why make this public
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Devamparikh commented on a diff in pull request #16595: Splitting assertMethod() method in different test cases
Posted by GitBox <gi...@apache.org>.
Devamparikh commented on code in PR #16595:
URL: https://github.com/apache/shardingsphere/pull/16595#discussion_r842391696
##########
shardingsphere-mode/shardingsphere-mode-type/shardingsphere-standalone-mode/shardingsphere-standalone-mode-repository/shardingsphere-standalone-mode-repository-provider/shardingsphere-standalone-mode-repository-h2/src/test/java/org/apache/shardingsphere/mode/repository/standalone/h2/H2RepositoryTest.java:
##########
@@ -34,38 +34,40 @@
@Test
public void assertMethod() {
assertThat(h2Repository.getType(), is("H2"));
- assertSetProperty();
- assertPersistAndGet();
- assertPersistAndGetChildrenKeys();
- assertDelete();
h2Repository.close();
}
-
- private void assertSetProperty() {
+
+ public void assertSetProperty() {
Review Comment:
Hey it was a mistake I have added a new PR.
Please check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Devamparikh closed pull request #16595: Splitting assertMethod() method in different test cases
Posted by GitBox <gi...@apache.org>.
Devamparikh closed pull request #16595: Splitting assertMethod() method in different test cases
URL: https://github.com/apache/shardingsphere/pull/16595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org