You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2015/09/14 22:55:41 UTC

Review Request 38368: Replaced slaveTaskStatusLabelDecorator hook with slaveTaskStatusDecorator hook.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38368/
-----------------------------------------------------------

Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen.


Bugs: MESOS-3013
    https://issues.apache.org/jira/browse/MESOS-3013


Repository: mesos


Description
-------

This allows the hook to not only update TaskStatus::labels, but also
TaskStatus::container_status.

Enhanced example hook module and relevant test to reflect the change.


Diffs
-----

  include/mesos/hook.hpp d90baccba4ac73eb777c8848e40ba737e756032f 
  src/examples/test_hook_module.cpp bc13a8ad0308668f31310b3aa65243bfb41b87b5 
  src/hook/manager.hpp 30d8321f459cacdfc0397ab7cd4e81710655351a 
  src/hook/manager.cpp 754c238fcf728d6aa5b897ed5d9f46c251345334 
  src/slave/slave.cpp 5e5522e1254a5ed6084de36782753f9aad2894c4 
  src/tests/common/http_tests.cpp bf8712b11339b409514ab86c1f32eaf7e9c9a2f1 
  src/tests/hook_tests.cpp deb4343089a30073e8f1f811731b075f7d968846 

Diff: https://reviews.apache.org/r/38368/diff/


Testing
-------

make check.


Thanks,

Kapil Arya


Re: Review Request 38368: Replaced slaveTaskStatusLabelDecorator hook with slaveTaskStatusDecorator hook.

Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38368/#review99334
-----------------------------------------------------------

Ship it!


Ship It!

- Niklas Nielsen


On Sept. 16, 2015, 3 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38368/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2015, 3 p.m.)
> 
> 
> Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3013
>     https://issues.apache.org/jira/browse/MESOS-3013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This allows the hook to not only update TaskStatus::labels, but also
> TaskStatus::container_status.
> 
> Enhanced example hook module and relevant test to reflect the change.
> 
> 
> Diffs
> -----
> 
>   include/mesos/hook.hpp d90baccba4ac73eb777c8848e40ba737e756032f 
>   src/examples/test_hook_module.cpp bc13a8ad0308668f31310b3aa65243bfb41b87b5 
>   src/hook/manager.hpp 30d8321f459cacdfc0397ab7cd4e81710655351a 
>   src/hook/manager.cpp 754c238fcf728d6aa5b897ed5d9f46c251345334 
>   src/slave/slave.cpp 44865bd2f7ab822829f93780ba1b883ffedb9842 
>   src/tests/hook_tests.cpp deb4343089a30073e8f1f811731b075f7d968846 
> 
> Diff: https://reviews.apache.org/r/38368/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Re: Review Request 38368: Replaced slaveTaskStatusLabelDecorator hook with slaveTaskStatusDecorator hook.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38368/
-----------------------------------------------------------

(Updated Sept. 16, 2015, 6 p.m.)


Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen.


Changes
-------

rebased; addressed issues


Bugs: MESOS-3013
    https://issues.apache.org/jira/browse/MESOS-3013


Repository: mesos


Description
-------

This allows the hook to not only update TaskStatus::labels, but also
TaskStatus::container_status.

Enhanced example hook module and relevant test to reflect the change.


Diffs (updated)
-----

  include/mesos/hook.hpp d90baccba4ac73eb777c8848e40ba737e756032f 
  src/examples/test_hook_module.cpp bc13a8ad0308668f31310b3aa65243bfb41b87b5 
  src/hook/manager.hpp 30d8321f459cacdfc0397ab7cd4e81710655351a 
  src/hook/manager.cpp 754c238fcf728d6aa5b897ed5d9f46c251345334 
  src/slave/slave.cpp 44865bd2f7ab822829f93780ba1b883ffedb9842 
  src/tests/hook_tests.cpp deb4343089a30073e8f1f811731b075f7d968846 

Diff: https://reviews.apache.org/r/38368/diff/


Testing
-------

make check.


Thanks,

Kapil Arya


Re: Review Request 38368: Replaced slaveTaskStatusLabelDecorator hook with slaveTaskStatusDecorator hook.

Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38368/#review99306
-----------------------------------------------------------



src/examples/test_hook_module.cpp (line 203)
<https://reviews.apache.org/r/38368/#comment156206>

    newline



src/hook/manager.cpp (line 248)
<https://reviews.apache.org/r/38368/#comment156207>

    newline



src/tests/common/http_tests.cpp (line 111)
<https://reviews.apache.org/r/38368/#comment156209>

    Instead of stringify, does it make sense to add an operator overload?



src/tests/hook_tests.cpp (line 524)
<https://reviews.apache.org/r/38368/#comment156208>

    newline


- Niklas Nielsen


On Sept. 15, 2015, 7:05 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38368/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2015, 7:05 p.m.)
> 
> 
> Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3013
>     https://issues.apache.org/jira/browse/MESOS-3013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This allows the hook to not only update TaskStatus::labels, but also
> TaskStatus::container_status.
> 
> Enhanced example hook module and relevant test to reflect the change.
> 
> 
> Diffs
> -----
> 
>   include/mesos/hook.hpp d90baccba4ac73eb777c8848e40ba737e756032f 
>   src/examples/test_hook_module.cpp bc13a8ad0308668f31310b3aa65243bfb41b87b5 
>   src/hook/manager.hpp 30d8321f459cacdfc0397ab7cd4e81710655351a 
>   src/hook/manager.cpp 754c238fcf728d6aa5b897ed5d9f46c251345334 
>   src/slave/slave.cpp 44865bd2f7ab822829f93780ba1b883ffedb9842 
>   src/tests/common/http_tests.cpp bf8712b11339b409514ab86c1f32eaf7e9c9a2f1 
>   src/tests/hook_tests.cpp deb4343089a30073e8f1f811731b075f7d968846 
> 
> Diff: https://reviews.apache.org/r/38368/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Re: Review Request 38368: Replaced slaveTaskStatusLabelDecorator hook with slaveTaskStatusDecorator hook.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38368/
-----------------------------------------------------------

(Updated Sept. 15, 2015, 10:05 p.m.)


Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen.


Changes
-------

rebased


Bugs: MESOS-3013
    https://issues.apache.org/jira/browse/MESOS-3013


Repository: mesos


Description
-------

This allows the hook to not only update TaskStatus::labels, but also
TaskStatus::container_status.

Enhanced example hook module and relevant test to reflect the change.


Diffs (updated)
-----

  include/mesos/hook.hpp d90baccba4ac73eb777c8848e40ba737e756032f 
  src/examples/test_hook_module.cpp bc13a8ad0308668f31310b3aa65243bfb41b87b5 
  src/hook/manager.hpp 30d8321f459cacdfc0397ab7cd4e81710655351a 
  src/hook/manager.cpp 754c238fcf728d6aa5b897ed5d9f46c251345334 
  src/slave/slave.cpp 44865bd2f7ab822829f93780ba1b883ffedb9842 
  src/tests/common/http_tests.cpp bf8712b11339b409514ab86c1f32eaf7e9c9a2f1 
  src/tests/hook_tests.cpp deb4343089a30073e8f1f811731b075f7d968846 

Diff: https://reviews.apache.org/r/38368/diff/


Testing
-------

make check.


Thanks,

Kapil Arya


Re: Review Request 38368: Replaced slaveTaskStatusLabelDecorator hook with slaveTaskStatusDecorator hook.

Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38368/
-----------------------------------------------------------

(Updated Sept. 15, 2015, 5:10 p.m.)


Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen.


Changes
-------

addressed comments.


Bugs: MESOS-3013
    https://issues.apache.org/jira/browse/MESOS-3013


Repository: mesos


Description
-------

This allows the hook to not only update TaskStatus::labels, but also
TaskStatus::container_status.

Enhanced example hook module and relevant test to reflect the change.


Diffs (updated)
-----

  include/mesos/hook.hpp d90baccba4ac73eb777c8848e40ba737e756032f 
  src/examples/test_hook_module.cpp bc13a8ad0308668f31310b3aa65243bfb41b87b5 
  src/hook/manager.hpp 30d8321f459cacdfc0397ab7cd4e81710655351a 
  src/hook/manager.cpp 754c238fcf728d6aa5b897ed5d9f46c251345334 
  src/slave/slave.cpp 5e5522e1254a5ed6084de36782753f9aad2894c4 
  src/tests/common/http_tests.cpp bf8712b11339b409514ab86c1f32eaf7e9c9a2f1 
  src/tests/hook_tests.cpp deb4343089a30073e8f1f811731b075f7d968846 

Diff: https://reviews.apache.org/r/38368/diff/


Testing
-------

make check.


Thanks,

Kapil Arya


Re: Review Request 38368: Replaced slaveTaskStatusLabelDecorator hook with slaveTaskStatusDecorator hook.

Posted by Kapil Arya <ka...@mesosphere.io>.

> On Sept. 14, 2015, 6:11 p.m., Niklas Nielsen wrote:
> > src/examples/test_hook_module.cpp, line 198
> > <https://reviews.apache.org/r/38368/diff/1/?file=1072969#file1072969line198>
> >
> >     How about setting the protocol (for testing)? So maybe have two network infos (one with each)?

Apparently, the protocol is of no use for TaskStatus decorator. It's only used when requesting IP (as mentioned in the comments for the protobuf). Dropping the issue. Feel free to reopen if needed.


- Kapil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38368/#review98928
-----------------------------------------------------------


On Sept. 15, 2015, 5:10 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38368/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2015, 5:10 p.m.)
> 
> 
> Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3013
>     https://issues.apache.org/jira/browse/MESOS-3013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This allows the hook to not only update TaskStatus::labels, but also
> TaskStatus::container_status.
> 
> Enhanced example hook module and relevant test to reflect the change.
> 
> 
> Diffs
> -----
> 
>   include/mesos/hook.hpp d90baccba4ac73eb777c8848e40ba737e756032f 
>   src/examples/test_hook_module.cpp bc13a8ad0308668f31310b3aa65243bfb41b87b5 
>   src/hook/manager.hpp 30d8321f459cacdfc0397ab7cd4e81710655351a 
>   src/hook/manager.cpp 754c238fcf728d6aa5b897ed5d9f46c251345334 
>   src/slave/slave.cpp 5e5522e1254a5ed6084de36782753f9aad2894c4 
>   src/tests/common/http_tests.cpp bf8712b11339b409514ab86c1f32eaf7e9c9a2f1 
>   src/tests/hook_tests.cpp deb4343089a30073e8f1f811731b075f7d968846 
> 
> Diff: https://reviews.apache.org/r/38368/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Re: Review Request 38368: Replaced slaveTaskStatusLabelDecorator hook with slaveTaskStatusDecorator hook.

Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38368/#review98928
-----------------------------------------------------------



src/examples/test_hook_module.cpp (line 197)
<https://reviews.apache.org/r/38368/#comment155657>

    Mind throwing in a comment about this test step?



src/examples/test_hook_module.cpp (line 198)
<https://reviews.apache.org/r/38368/#comment155664>

    How about setting the protocol (for testing)? So maybe have two network infos (one with each)?



src/slave/slave.cpp (lines 2757 - 2765)
<https://reviews.apache.org/r/38368/#comment155661>

    Can we either add a warning if anything else is changed (probably hard) or at least throw in a comment, that we only apply changes from container status and labels?



src/tests/hook_tests.cpp (line 513)
<https://reviews.apache.org/r/38368/#comment155663>

    Mind preceeding this test code blob with a comment about the setup?


- Niklas Nielsen


On Sept. 14, 2015, 1:55 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38368/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2015, 1:55 p.m.)
> 
> 
> Review request for mesos, Connor Doyle, Jie Yu, and Niklas Nielsen.
> 
> 
> Bugs: MESOS-3013
>     https://issues.apache.org/jira/browse/MESOS-3013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This allows the hook to not only update TaskStatus::labels, but also
> TaskStatus::container_status.
> 
> Enhanced example hook module and relevant test to reflect the change.
> 
> 
> Diffs
> -----
> 
>   include/mesos/hook.hpp d90baccba4ac73eb777c8848e40ba737e756032f 
>   src/examples/test_hook_module.cpp bc13a8ad0308668f31310b3aa65243bfb41b87b5 
>   src/hook/manager.hpp 30d8321f459cacdfc0397ab7cd4e81710655351a 
>   src/hook/manager.cpp 754c238fcf728d6aa5b897ed5d9f46c251345334 
>   src/slave/slave.cpp 5e5522e1254a5ed6084de36782753f9aad2894c4 
>   src/tests/common/http_tests.cpp bf8712b11339b409514ab86c1f32eaf7e9c9a2f1 
>   src/tests/hook_tests.cpp deb4343089a30073e8f1f811731b075f7d968846 
> 
> Diff: https://reviews.apache.org/r/38368/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>