You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@hive.apache.org by "Ashutosh Chauhan (JIRA)" <ji...@apache.org> on 2014/11/13 02:12:52 UTC

[jira] [Commented] (HIVE-8284) Equality comparison is done between two floating point variables in HiveRelMdUniqueKeys#getUniqueKeys()

    [ https://issues.apache.org/jira/browse/HIVE-8284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14209025#comment-14209025 ] 

Ashutosh Chauhan commented on HIVE-8284:
----------------------------------------

+1

> Equality comparison is done between two floating point variables in HiveRelMdUniqueKeys#getUniqueKeys()
> -------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-8284
>                 URL: https://issues.apache.org/jira/browse/HIVE-8284
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.14.0
>            Reporter: Ted Yu
>            Assignee: JongWon Park
>            Priority: Minor
>         Attachments: HIVE-8284.patch
>
>
> {code}
>     double numRows = tScan.getRows();
> ...
>         double r = cStat.getRange().maxValue.doubleValue() -
>             cStat.getRange().minValue.doubleValue() + 1;
>         isKey = (numRows == r);
> {code}
> The equality check should use a small epsilon as tolerance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)