You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Jens Geyer (JIRA)" <ji...@apache.org> on 2016/04/22 21:48:12 UTC

[jira] [Resolved] (THRIFT-3795) Generated hashValue method in Swift will overflow

     [ https://issues.apache.org/jira/browse/THRIFT-3795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jens Geyer resolved THRIFT-3795.
--------------------------------
       Resolution: Fixed
         Assignee: Håkon Hitland
    Fix Version/s: 0.10.0

Committed.

> Generated hashValue method in Swift will overflow
> -------------------------------------------------
>
>                 Key: THRIFT-3795
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3795
>             Project: Thrift
>          Issue Type: Bug
>          Components: Swift - Compiler
>    Affects Versions: 0.9.3
>            Reporter: Håkon Hitland
>            Assignee: Håkon Hitland
>            Priority: Minor
>             Fix For: 0.10.0
>
>         Attachments: overflow.patch
>
>
> The generated hashValue code for Swift uses the + and * arithmetic operators, for which an overflow is a fatal error.
> The intention is probably to wrap around, so the overflow operators should be used instead.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)