You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by al...@apache.org on 2022/02/18 00:42:47 UTC
[kudu] branch master updated (5f0964a -> 8a26e84)
This is an automated email from the ASF dual-hosted git repository.
alexey pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git.
from 5f0964a [tserver] avoid copying Schema in SplitKeyRange()
new d2b1d2f [security] harmonize tls_handshake.cc
new b18e07a [util] harmonize logging.h
new 8a26e84 [security] harmonize updates to mini_kdc
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
src/kudu/security/test/mini_kdc.cc | 4 +++-
src/kudu/security/tls_handshake.cc | 2 +-
src/kudu/util/logging.h | 2 +-
3 files changed, 5 insertions(+), 3 deletions(-)
[kudu] 02/03: [util] harmonize logging.h
Posted by al...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
alexey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
commit b18e07a18fec1ecc868e18acbf06a19f4d8a410f
Author: Andrew Wong <aw...@cloudera.com>
AuthorDate: Wed Feb 16 18:40:45 2022 -0800
[util] harmonize logging.h
This adds the ::kudu namespace to logging::LogThrottler, to match
changes required for Impala to use the library.
Change-Id: Ie3c6a4597cda3077df3374e907eb8672d279d9e9
Reviewed-on: http://gerrit.cloudera.org:8080/18247
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
src/kudu/util/logging.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/kudu/util/logging.h b/src/kudu/util/logging.h
index f8b03b5..8e2241f 100644
--- a/src/kudu/util/logging.h
+++ b/src/kudu/util/logging.h
@@ -162,7 +162,7 @@ class ScopedDisableRedaction {
&google::LogMessage::SendToLog).stream()
#define KLOG_EVERY_N_SECS(severity, n_secs) \
- static logging::LogThrottler LOG_THROTTLER; \
+ static ::kudu::logging::LogThrottler LOG_THROTTLER; \
KLOG_EVERY_N_SECS_THROTTLER(severity, n_secs, LOG_THROTTLER, "no-tag")
#define WARN_NOT_OK_EVERY_N_SECS(to_call, warning_prefix, n_secs) do { \
[kudu] 03/03: [security] harmonize updates to mini_kdc
Posted by al...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
alexey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
commit 8a26e843a1ff5a807a4b6f1c77f6146bc5156398
Author: Andrew Wong <aw...@cloudera.com>
AuthorDate: Wed Feb 16 18:32:00 2022 -0800
[security] harmonize updates to mini_kdc
Impala recently rebased their Kudu libraries and ran into some build
issues. This patch addresses one:
An Impala backend test calls MiniKdc::Kinit() with parameter
"dummy/host", but "/" caused a runtime error in MiniKdc::Kinit(). This
patch replaces "/" with "_" when creating the template. The same is not
done for principal names, which can consist "/".
This is a follow-up to 8133fbfb734c18be8f4abb3ee83ac9dd0cc4ce16.
Change-Id: I60bd9a0bf3113a689a252182b4e6292dff12a9e7
Reviewed-on: http://gerrit.cloudera.org:8080/18245
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
src/kudu/security/test/mini_kdc.cc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/kudu/security/test/mini_kdc.cc b/src/kudu/security/test/mini_kdc.cc
index 831699c..7e6a0e8 100644
--- a/src/kudu/security/test/mini_kdc.cc
+++ b/src/kudu/security/test/mini_kdc.cc
@@ -309,7 +309,9 @@ Status MiniKdc::Kinit(const string& username) {
RETURN_NOT_OK(GetBinaryPath("kinit", &kinit));
unique_ptr<WritableFile> tmp_cc_file;
string tmp_cc_path;
- const auto tmp_template = Substitute("kinit-temp-$0.XXXXXX", username);
+ string tmp_username = username;
+ StripString(&tmp_username, "/", '_');
+ const auto tmp_template = Substitute("kinit-temp-$0.XXXXXX", tmp_username);
WritableFileOptions opts;
opts.is_sensitive = false;
RETURN_NOT_OK_PREPEND(Env::Default()->NewTempWritableFile(
[kudu] 01/03: [security] harmonize tls_handshake.cc
Posted by al...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
alexey pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kudu.git
commit d2b1d2f40f6fc4aacf73b2cc865a9e5c35e00c10
Author: Andrew Wong <aw...@cloudera.com>
AuthorDate: Wed Feb 16 18:37:54 2022 -0800
[security] harmonize tls_handshake.cc
The first parameter of Socket.Write() is of type `const uint8_t *`. This
resulted in a warning in TlsHandshake::Finish(). This caused an Impala
build failure since the warning was treated as an error.
This is a follow-up to df6590d26d.
Change-Id: Iddf1bd7ee39ea74eff74871c83c5159e53fc7377
Reviewed-on: http://gerrit.cloudera.org:8080/18246
Tested-by: Alexey Serbin <as...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
src/kudu/security/tls_handshake.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/kudu/security/tls_handshake.cc b/src/kudu/security/tls_handshake.cc
index c313308..82e22e0 100644
--- a/src/kudu/security/tls_handshake.cc
+++ b/src/kudu/security/tls_handshake.cc
@@ -313,7 +313,7 @@ Status TlsHandshake::Finish(unique_ptr<Socket>* socket) {
if (data_size != 0) {
int fd = SSL_get_fd(ssl);
Socket sock(fd);
- uint8_t* data = reinterpret_cast<uint8_t*>(rbio_pending_data_.data());
+ const uint8_t* data = reinterpret_cast<const uint8_t*>(rbio_pending_data_.data());
int32_t written = 0;
RETURN_NOT_OK(sock.Write(data, data_size, &written));
if (written != data_size) {