You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/23 11:05:00 UTC

[GitHub] [airflow] kaxil commented on a change in pull request #9487: Replace deprecated wtforms HTMLString with markupsafe.MarkUp

kaxil commented on a change in pull request #9487:
URL: https://github.com/apache/airflow/pull/9487#discussion_r444141552



##########
File path: setup.py
##########
@@ -709,6 +709,7 @@ def is_package_excluded(package: str, exclusion_list: List[str]):
     'lazy_object_proxy~=1.3',
     'lockfile>=0.12.2',
     'markdown>=2.5.2, <3.0',
+    'markupsafe>=1.1.1, <2.0',

Review comment:
       It is not a new dependency as it was already required by jinja2, Flask-App builder etc
   
   https://github.com/dpgaspar/Flask-AppBuilder/blob/master/requirements.txt

##########
File path: setup.py
##########
@@ -709,6 +709,7 @@ def is_package_excluded(package: str, exclusion_list: List[str]):
     'lazy_object_proxy~=1.3',
     'lockfile>=0.12.2',
     'markdown>=2.5.2, <3.0',
+    'markupsafe>=1.1.1, <2.0',

Review comment:
       It is not a new dependency as it was already required by jinja2, Flask-AppBuilder etc
   
   https://github.com/dpgaspar/Flask-AppBuilder/blob/master/requirements.txt




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org