Integer validation in WSDL2C.sh generated code

[slowpoison <sl...@comcast.net>]

I noticed that there is no validation for integers in the generated
code. For example if I define by integer to be of type
positiveInteger, the code won't check that it's zero.

I'm wondering if there is a way to do this.
If not, I'd like to know how easy/hard will it be to add it. I'm
willing to spend some time to write a patch for that. Just sizing up
the effort first.

thanks!
-vish

Re: Integer validation in WSDL2C.sh generated code

[Nandika Jayawardana <ja...@gmail.com>]

We always welcome contributions. Please raise a jira and attach your changes
as a patch.

Regards
Nandika

On Wed, Jan 27, 2010 at 6:24 AM, slowpoison <sl...@comcast.net> wrote:

> On Fri, Jan 22, 2010 at 10:57 PM, Sanjiva Weerawarana
> <sa...@opensource.lk> wrote:
> > Why not get the script to run the generated code thru a pretty printer?
>
> True. But, why add an extra step.
> Besides, I have seen that running the code through pretty printer
> still leaves something to be desired. For example comments are not
> formatted properly.
>
> If there's interest in accepting my changes, I'm willing to put in the
> effort. :)
>



-- 
http://nandikajayawardana.blogspot.com/
WSO2 Inc: http://www.wso2.com

Re: Integer validation in WSDL2C.sh generated code

[slowpoison <sl...@comcast.net>]

On Fri, Jan 22, 2010 at 10:57 PM, Sanjiva Weerawarana
<sa...@opensource.lk> wrote:
> Why not get the script to run the generated code thru a pretty printer?

True. But, why add an extra step.
Besides, I have seen that running the code through pretty printer
still leaves something to be desired. For example comments are not
formatted properly.

If there's interest in accepting my changes, I'm willing to put in the
effort. :)

Re: Integer validation in WSDL2C.sh generated code

[Sanjiva Weerawarana <sa...@opensource.lk>]

Why not get the script to run the generated code thru a pretty printer?

Sanjiva.

On Sat, Jan 23, 2010 at 6:21 AM, slowpoison <sl...@comcast.net> wrote:

> On Wed, Jan 20, 2010 at 3:19 AM, Samisa Abeysinghe <sa...@wso2.com>
> wrote:
> > Should be a matter of updating the XSLTs used for code generation.
>
> OK, great. I'll try to see what I can add.
>
> Also, is there interest in fixing the formatting of the generated
> code? The formatting is, sorry to say, awful. I can take a shot at
> that too.
>



-- 
Sanjiva Weerawarana, Ph.D.
Founder, Director & Chief Scientist; Lanka Software Foundation;
http://www.opensource.lk/
Founder, Chairman & CEO; WSO2, Inc.; http://www.wso2.com/
Member; Apache Software Foundation; http://www.apache.org/
Visiting Lecturer; University of Moratuwa; http://www.cse.mrt.ac.lk/

Blog: http://sanjiva.weerawarana.org/

Re: Integer validation in WSDL2C.sh generated code

[slowpoison <sl...@comcast.net>]

On Wed, Jan 20, 2010 at 3:19 AM, Samisa Abeysinghe <sa...@wso2.com> wrote:
> Should be a matter of updating the XSLTs used for code generation.

OK, great. I'll try to see what I can add.

Also, is there interest in fixing the formatting of the generated
code? The formatting is, sorry to say, awful. I can take a shot at
that too.

Re: Integer validation in WSDL2C.sh generated code

[Samisa Abeysinghe <sa...@wso2.com>]

On Wed, Jan 20, 2010 at 9:23 AM, slowpoison <sl...@comcast.net> wrote:

> I noticed that there is no validation for integers in the generated
> code. For example if I define by integer to be of type
> positiveInteger, the code won't check that it's zero.
>
> I'm wondering if there is a way to do this.
>

Not right now.


> If not, I'd like to know how easy/hard will it be to add it.


Should be a matter of updating the XSLTs used for code generation.

Samisa...



> I'm
> willing to spend some time to write a patch for that. Just sizing up
> the effort first.
>
> thanks!
> -vish
>



-- 
Samisa Abeysinghe
Director, Engineering - WSO2 Inc.

http://www.wso2.com/ - "lean . enterprise . middleware"