You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2020/08/28 23:00:11 UTC

[GitHub] [systemds] mboehm7 commented on pull request #1031: [SYSTEMDS-2555] Federated transform dummycoding encoding decoding

mboehm7 commented on pull request #1031:
URL: https://github.com/apache/systemds/pull/1031#issuecomment-683181290


   LGTM - thanks @kev-inn for this solid patch. I only did some minor cleanups (arrays.fill/streams where applicable, removed csv property handling on read) and left a performance TODO. For dummycode decode, it would be important (once we come to performance improvements) to work with sparse matrices directly to avoid unnecessarily bad asymptotic behavior (O(m n log n) vs O(nnz))


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org