[GitHub] nifi pull request #1341: NIFI-3153 Update AWS SDK

[jvwing <gi...@git.apache.org>]

GitHub user jvwing opened a pull request:

    https://github.com/apache/nifi/pull/1341

    NIFI-3153 Update AWS SDK

    As part of upgrading the AWS SDK, I ran the suite of AWS integration tests.  Getting the integration tests to succeed required a couple of changes detailed below, none of which I believe to be caused by the SDK change:
    
    * ITPutS3Object.testGetPropertyDescriptors - bumped up the expected number of Property Descriptors to match the actual number.
    * ITPutS3Object.testContentType - Ignored. The test checks if the content type was written to the flowfile attributes after writing the content to S3.  I did not find any place in the PutS3Object code that attempts this, uses the S3_CONTENT_TYPE constant, or that was submitted with NIFI-2810.  I created a separate ticket to investigate, NIFI-3228.
    
    ----
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [X] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [X] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [X] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jvwing/nifi NIFI-3153-update-aws-sdk-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/1341.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1341
    
----
commit eb75984af8d1185bab26c12b70da8f8a2568f313
Author: James Wing <jv...@gmail.com>
Date:   2016-12-17T21:30:27Z

    NIFI-3153 Updating AWS SDK Version

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi pull request #1341: NIFI-3153 Update AWS SDK

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/nifi/pull/1341


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nifi issue #1341: NIFI-3153 Update AWS SDK

[jvwing <gi...@git.apache.org>]

Github user jvwing commented on the issue:

    https://github.com/apache/nifi/pull/1341
  
    I rebased the PR branch on the latest master, which contains the fix for NIFI-3228.  I no longer set the `ITPutS3Object.testContentType` integration test to `@Ignore`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---